Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP SI spilling over/being cut off making the NTP page scrollable on smaller screens #21736

Closed
kjozwiak opened this issue Mar 17, 2022 · 4 comments · Fixed by brave/brave-core#12711
Labels
bug feature/new-tab OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@kjozwiak
Copy link
Member

Description

On some older devices that have a smaller screen, sometimes the NTP SI spills to the bottom which in turn cuts off parts of the SI and makes the NTP page scrollable even though Brave News hasn't been disabled. Originally reported by @bradleyrichter and very similar #21511 which was reported by @LaurenWags

Steps to reproduce

Unfortunately I don't have STR/Cases as this was reported by others but seems like simply loading the NTP on a small screen will cause the issue to appear.

Actual result

Screenshot_20220316-171315

Expected result

Screenshot_20220316-222338

Issue reproduces how often

As per the above, I personally didn't run into this issue but sounds like it's 100% reproducible if you have a small enough screen.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone (might need @bradleyrichter to provide model)
  • Android version: Android 8

Brave version

1.36.117 Chromium 99.0.4844.74

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @bradleyrichter @alexsafe @anthonypkeane @bsclifton

@kjozwiak kjozwiak added bug feature/new-tab QA/Yes OS/Android Fixes related to Android browser functionality labels Mar 17, 2022
@kjozwiak kjozwiak added this to Backlog in Android General via automation Mar 17, 2022
@anthonypkeane anthonypkeane moved this from Backlog to P2 in Android General Mar 17, 2022
@anthonypkeane anthonypkeane added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 17, 2022
@kjozwiak
Copy link
Member Author

Closing as this was fixed via brave/brave-core#12711 and already merged into 1.38.x.

Android General automation moved this from P2 to Done/Closed Mar 28, 2022
@kjozwiak
Copy link
Member Author

kjozwiak commented Mar 28, 2022

Above requires 1.37.107 or newer for 1.37.x verification.

@kjozwiak
Copy link
Member Author

kjozwiak commented Mar 29, 2022

Verification PASSED on Pixel 6 running Android 12 using 1.37.107 Chromium 100.0.4896.46

Went through the STR/Cases outlined via #21736 (comment) & brave/brave-core#12711 (comment).

Example Example
Screenshot_20220329-004243 Screenshot_20220329-004313
  • also ensured that you can click on the text under the SI NTP and it correctly opens a new tab with the targeted campaign.

Verification PASSED on Samsung S10+ running Android 12 using 1.37.107 Chromium 100.0.4896.46

Went through the STR/Cases outlined via #21736 (comment) & brave/brave-core#12711 (comment).

Example Example
Screenshot_20220329-005030_Brave Screenshot_20220329-004945_Brave
  • also ensured that you can click on the text under the SI NTP and it correctly opens a new tab with the targeted campaign.

Verification PASSED on Samsung Galaxy Tablet A running Android 12 using 1.37.107 Chromium 100.0.4896.46

Went through the STR/Cases outlined via #21736 (comment) & brave/brave-core#12711 (comment).

Example Example
Screenshot_20220329-005957_Brave Screenshot_20220329-010016_Brave
  • also ensured that you can click on the text under the SI NTP and it correctly opens a new tab with the targeted campaign.

Verification PASSED on Samsung Galaxy Tab A7 version 11 running Bravemonoarm.64_1.37.107

Example Example Example
Screenshot_20220329-140959_Brave Screenshot_20220329-141014_Brave Screenshot_20220329-141026_Brave

@kjozwiak
Copy link
Member Author

@bradleyrichter also verified that the above was working for him on Nightly via brave/brave-core#12711 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/new-tab OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Android General
  
Done/Closed
Development

Successfully merging a pull request may close this issue.

2 participants