Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Fix NTP SI, imagecredit cutoff #12711

Merged
merged 2 commits into from
Mar 25, 2022

Conversation

tapanmodh
Copy link
Contributor

Resolves brave/brave-browser#21736

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@tapanmodh tapanmodh added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Mar 23, 2022
@tapanmodh tapanmodh requested a review from alexsafe March 23, 2022 05:34
@tapanmodh tapanmodh self-assigned this Mar 23, 2022
@tapanmodh tapanmodh added this to the 1.38.x - Nightly milestone Mar 23, 2022
Copy link
Contributor

@alexsafe alexsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 12 using 1.39.9 Chromium: 100.0.4896.46

Using the STR/Cases outlined via brave/brave-browser#21736, ensured that the SI NTP were not being cut off as per the following:

Example Example Example
Screenshot_20220328-010227 Screenshot_20220328-010149 Screenshot_20220328-010210

@bradleyrichter was initially the person that reported the original issue and also verified that it was fixed on the affected device as per the following:

Before Fix After Fix
Screenshot_20220325-153729 Screenshot_20220325-153507

Also ensured that you can click on the text under the SI NTP and it correctly opens a new tab with the targeted campaign.

@kjozwiak
Copy link
Member

Changing the milestone as this landed in 1.39.x and not 1.38.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
3 participants