Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels for settings in the Shields v2 Panel and settings page don't match design #21916

Closed
pes10k opened this issue Mar 27, 2022 · 3 comments · Fixed by brave/brave-core#12775
Closed

Labels for settings in the Shields v2 Panel and settings page don't match design #21916

pes10k opened this issue Mar 27, 2022 · 3 comments · Fixed by brave/brave-core#12775
Assignees
@nullhook
Labels
feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.38.x - Release

Comments

@pes10k
Copy link
Contributor

pes10k commented Mar 27, 2022

Not linking to the gdoc (its in the figma file) but the labels for many of the drop-down options in the shields panel and brave://settings/shields have not been updated to match the new discussed labels.
@pes10k pes10k added feature/shields The overall Shields feature in Brave. feature/shields/panel Front-end design and functionality of the Shields panel. OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 27, 2022
@nullhook nullhook mentioned this issue Mar 28, 2022
Merged
25 tasks
@nullhook nullhook self-assigned this Mar 28, 2022
@nullhook
Copy link

nullhook commented Mar 28, 2022 •
edited
Loading

we'll update labels on brave://settings/shields as a follow up in a separate issue. This issue would only resolve on v2 panel first and wouldn't impact on android. cc @rebron

@nullhook nullhook added QA/Yes release-notes/exclude and removed OS/Android Fixes related to Android browser functionality labels Mar 28, 2022
@nullhook nullhook added this to the 1.39.x - Nightly milestone Apr 3, 2022
@nullhook nullhook mentioned this issue Apr 6, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Apr 8, 2022

Above requires 1.38.85 or higher for 1.38.x verification.

@stephendonner
Copy link

stephendonner commented Apr 23, 2022 •
edited
Loading

Verified PASSED using

Brave 1.38.105 Chromium: 101.0.4951.41 (Official Build) (x86_64)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS macOS Version 11.6.5 (Build 20G527)

1. Shields Panel: Verified over in #22084 (comment)

2. brave://settings/shields: Will be verified over in #21926

3. Shields panel & brave://settings/shields: Both also extensively tested both explicitly and implicitly via #18630 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullhook nullhook

Labels
feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

Updated labels for Shields v2 panel brave/brave-core
4 participants
@pes10k @stephendonner @kjozwiak @nullhook