Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields v2, match labels for cookies and fingerprinting to spec #22084

Closed
rebron opened this issue Apr 4, 2022 · 3 comments · Fixed by brave/brave-core#12885 or brave/brave-core#12894
Assignees
Labels
feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Apr 4, 2022

Description

See: https://www.figma.com/file/3A6F6VrxVahiZFxLr7j7FO/Desktop-Brave-Shields

Steps to Reproduce

  1. Use 1.39.28 and higher
  2. Open shields and open up menu items for fingerprinting and cookies in advanced controls
  3. Notice label order. Should match spec with aggressive and block all (respectively) as the top most items.

Actual result:

Screen Shot 2022-04-04 at 4 35 21 PM

Screen Shot 2022-04-04 at 4 35 29 PM

Expected result:

Screen Shot 2022-04-04 at 4 41 07 PM

Reproduces how often:

Easily.

Brave version (brave://version info)

1.39.28.x and higher

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Needs to uplift to 1.38.x once issue is verified in 1.39.x

@rebron rebron added OS/Desktop feature/shields/panel Front-end design and functionality of the Shields panel. priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Apr 4, 2022
@rebron
Copy link
Collaborator Author

rebron commented Apr 4, 2022

cc: @aguscruiz

@kjozwiak
Copy link
Member

kjozwiak commented Apr 8, 2022

Above requires 1.38.85 or higher for 1.38.x verification.

@rebron rebron added the feature/shields The overall Shields feature in Brave. label Apr 19, 2022
@stephendonner
Copy link

stephendonner commented Apr 22, 2022

Verified PASSED using

Brave 1.38.104 Chromium: 101.0.4951.41 (Official Build) (x86_64)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS macOS Version 12.4 (Build 21F5058e)

Confirmed the ordering of cookies and fingerprint-blocking options now match the Figma spec.

Figma
161649863-74aa1056-d325-4e5f-af98-74d45d8d7123 (1)

Default panel Trackers & ads Fingerprinting Cookies
Screen Shot 2022-04-21 at 10 45 42 PM Screen Shot 2022-04-21 at 10 25 26 PM Screen Shot 2022-04-21 at 10 27 09 PM Screen Shot 2022-04-21 at 10 27 39 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants