Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global defaults inconsistent appearance when Shields are down #22217

Closed
MadhaviSeelam opened this issue Apr 11, 2022 · 5 comments · Fixed by brave/brave-core#12994
Closed

Global defaults inconsistent appearance when Shields are down #22217

MadhaviSeelam opened this issue Apr 11, 2022 · 5 comments · Fixed by brave/brave-core#12994
Assignees
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@MadhaviSeelam
Copy link

Description

When Shields are down, Global default hyperlink display black initially and after hovering over second time, it turns blue.

Steps to Reproduce

  1. Install 1.38.83
  2. Launch Brave
  3. Visit Washingtonpost.com
  4. Click Shields icon
  5. Disable Shields

Actual result:

Global defaults hyperlink appears black. Appeared blue after hovered over twice.

globaldefaultslink

Expected result:

Global defaults hyperlink should display blue.

Reproduces how often:

Easy

Brave version (brave://version info)

Version/Channel Information:

Brave 1.38.83 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS Windows 11 Version 21H2 (Build 22000.593)
  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@MadhaviSeelam MadhaviSeelam added bug feature/shields The overall Shields feature in Brave. QA/Test-Plan-Specified feature/shields/panel Front-end design and functionality of the Shields panel. OS/Desktop labels Apr 11, 2022
@MadhaviSeelam MadhaviSeelam changed the title Global defaults appearance inconsistency when Shields are down Global defaults inconsistent appearance when Shields are down Apr 11, 2022
@rebron
Copy link
Collaborator

rebron commented Apr 11, 2022

cc: @aguscruiz Can you clarify the hover state in @MadhaviSeelam's example for the Global defaults link. Closed Shields panel (black hyperlink, blue on hover) is different from Shields on/Advanced controls expanded for Filter lists and Global defaults link (blue hyperlink, no change on hover).

@rebron rebron assigned aguscruiz and unassigned rebron Apr 11, 2022
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude labels Apr 11, 2022
@aguscruiz
Copy link

aguscruiz commented Apr 12, 2022

Edited:

Light mode default

  • label: light-theme/brand/interactive06
  • icon: light-theme/brand/interactive 05

Light mode hover:

  • label: light-theme/brand/interactive 05
  • icon:light-theme/brand/ interactive 04

Dark mode default:

  • label: dark-theme/brand/focus-border
  • icon: dark-theme/brand/interactive 06

Dark mode hover:

  • label: dark-theme/brand/interactive 06
  • icon: dark-theme/brand/interactive 05

@kjozwiak
Copy link
Member

Above requires 1.38.102 or higher for 1.38.x verification.

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.38.103 Chromium: 100.0.4896.127 (Official Build) beta (64-bit)
-- | --
Revision | ff0d0695743e65305d7194f9bd309e5e1c824aa0-refs/branch-heads/4896_88@{#4}
OS | Windows 10 Version 21H2 (Build 19044.1645)

  • Verified the STR from the description and ensured Global defaults is shown in blue color when shields are down
    image

@MadhaviSeelam
Copy link
Author

Verification Passed on

Brave 1.38.104 Chromium: 101.0.4951.41 (Official Build) (64-bit)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS Windows 11 Version 21H2 (Build 22000.613)

Verified the bug fix on Shields UP and Shields Down panels. QA complete.

shields panel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants