Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Center the Add button on Add networks setting screen #22220

Closed
Pavneet-Sing opened this issue Apr 11, 2022 · 1 comment · Fixed by brave/brave-core#13069
Closed

Center the Add button on Add networks setting screen #22220

Pavneet-Sing opened this issue Apr 11, 2022 · 1 comment · Fixed by brave/brave-core#13069
Assignees
@qamarngr
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Milestone
1.40.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Apr 11, 2022 •
edited
Loading

Description

The button is not in the center

Steps to reproduce

  1. Goto Settings
  2. Choose Brave Wallet => Networks
  3. Click on Add networks

Actual result

The Add button on the left

Expected result

The Add button should be in the center

Issue reproduces how often

easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): All
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

All

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Additional information

  • Also fix the padding issue 21056
  • Add a little space at the bottom of the add button as well, to separate its edges from the bottom bar.
@Pavneet-Sing Pavneet-Sing added OS/Android Fixes related to Android browser functionality bug QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 11, 2022
@stephendonner stephendonner changed the title Center the Add button on Add networks setting scren Center the Add button on Add networks setting screen Apr 15, 2022
qamarngr added a commit to qamarngr/brave-core that referenced this issue Apr 18, 2022
@qamarngr
fixed add button on wallet add network
d08a8ac 
Fixes brave/brave-browser#22220
Fixes brave/brave-browser#21056
@qamarngr qamarngr mentioned this issue Apr 18, 2022
Closed
25 tasks
qamarngr added a commit to qamarngr/brave-core that referenced this issue Apr 19, 2022
@qamarngr
fixed alignment and styling of add button
5687557 
On the Screen
Settings->Brave Wallet-> Networks-> Add Network
Made the button center-aligned removed extra padding and used style BraveWalletButtonStyle

Fixes brave/brave-browser#22220
Fixes brave/brave-browser#21056
@qamarngr qamarngr mentioned this issue Apr 19, 2022
Merged
25 tasks
qamarngr added a commit to brave/brave-core that referenced this issue Apr 28, 2022
@qamarngr
Merge pull request #13069 from brave/
be1170a 
On the Screen
Settings->Brave Wallet-> Networks-> Add Network
Made the button center-aligned removed extra padding and used style BraveWalletButtonStyle

Fixes brave/brave-browser#22220
Fixes brave/brave-browser#21056
@qamarngr qamarngr added this to the 1.40.x - Nightly milestone May 4, 2022
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.40.101 x64 build

  • Verified Add button is center aligned in Add Networks settings screen
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qamarngr qamarngr

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.40.x - Release
3 participants
@qamarngr @Pavneet-Sing @srirambv