Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed add button on wallet add network #13051

Closed

Conversation

qamarngr
Copy link
Contributor

@qamarngr qamarngr commented Apr 18, 2022

Fixes brave/brave-browser#22220
Fixes brave/brave-browser#21056

Resolves
brave/brave-browser#22220
brave/brave-browser#21056

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Pavneet-Sing Pavneet-Sing self-requested a review April 19, 2022 06:15
@Pavneet-Sing
Copy link

Copy link

@Pavneet-Sing Pavneet-Sing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Comment on lines +230 to 231
android:layout_marginStart="12dp"
android:layout_marginEnd="12dp"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can replace these with android:layout_marginHorizontal

Comment on lines +235 to +236
android:paddingStart="8dp"
android:paddingEnd="8dp"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can be replaced with android:paddingHorizontal

@qamarngr qamarngr closed this Apr 19, 2022
@qamarngr qamarngr deleted the fix_add_button_on_add_networks branch April 19, 2022 20:22
@Pavneet-Sing
Copy link

The corresponding issues has been resolved by the #13069 PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants