Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed alignment and styling of add button #13069

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

qamarngr
Copy link
Contributor

@qamarngr qamarngr commented Apr 19, 2022

On the Screen
Settings->Brave Wallet-> Networks-> Add Network
Made the button center-aligned removed extra padding and used style BraveWalletButtonStyle

Fixes brave/brave-browser#22220
Fixes brave/brave-browser#21056
Screenshot_20220419-223446

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

On the Screen
Settings->Brave Wallet-> Networks-> Add Network
Made the button center-aligned removed extra padding and used style BraveWalletButtonStyle

Fixes brave/brave-browser#22220
Fixes brave/brave-browser#21056
@qamarngr qamarngr added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 19, 2022
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link

@Pavneet-Sing Pavneet-Sing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@qamarngr qamarngr merged commit be1170a into brave:master Apr 28, 2022
@qamarngr qamarngr added this to the 1.40.x - Nightly milestone May 4, 2022
@qamarngr qamarngr deleted the fix_add_button_style_on_add_network branch May 6, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
3 participants