Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support of .888 for UD #24922

Closed
supermassive opened this issue Aug 24, 2022 · 1 comment · Fixed by brave/brave-core#14793
Closed

Drop support of .888 for UD #24922

supermassive opened this issue Aug 24, 2022 · 1 comment · Fixed by brave/brave-core#14793
Assignees
@supermassive
Labels
feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.45.x - Release

Comments

@supermassive
Copy link
Collaborator

supermassive commented Aug 24, 2022 •
edited

https://github.com/brave/security/issues/981
brave/brave-core#14588 (comment)
@supermassive supermassive self-assigned this Aug 24, 2022
@supermassive supermassive mentioned this issue Aug 24, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Aug 26, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Sep 28, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Linux
  • Verified steps from brave/brave-core#14793
  • Verified .888 domains don't resolve
  • Verified error message is shown when a .888 domain is typed/pasted into Send field
  • Logged #26065
    image

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Windows 11 Version 21H2 (Build 22000.978)
  • Verified steps from brave/brave-core#14793
  • Verified .888 domains don't resolve
  • Verified error message is shown when a .888 domain is typed/pasted into Send field
  • Logged #26065
    image

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (arm64)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#14793
  • Verified .888 domains don't resolve
  • Verified error message is shown when a .888 domain is typed/pasted into Send field
  • Logged #26065
    image

@LaurenWags LaurenWags mentioned this issue Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/unstoppable-domains Label for unstoppable domains feature feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.45.x - Release
Development

Successfully merging a pull request may close this issue.

Drop .888 support for UD brave/brave-core
4 participants
@supermassive @srirambv @LaurenWags @brave-builds