Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Forget By Default" feature #26465

Closed
pes10k opened this issue Nov 2, 2022 · 11 comments
Closed

"Forget By Default" feature #26465

pes10k opened this issue Nov 2, 2022 · 11 comments
Assignees
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/shields/forgetful-browsing OS/Android Fixes related to Android browser functionality OS/Desktop privacy/feature User-facing privacy- & security-focused feature work. privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA Pass - Android 8+ QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@pes10k
Copy link
Contributor

pes10k commented Nov 2, 2022

  1. Brave should have a storage setting in shields that clears first-party data automatically when browsing away from a site
  2. Brave should give users a convenient way to “opt-into” a site remembering them (instead of making it the default)
  3. This overall “forget by default” feature should be opt-in, though we should build things in a way that would allow us to "nudge" users in cases where they are using a site they might want to maintain storage on (i.e., hint to users they might want to opt-in)
  4. There's a timeout of 30 seconds after site close before data is cleared.

Spec is available in #specs in Slack: https://bravesoftware.slack.com/archives/CELA35G5S/p1666392931428619

Current state (1.54.x)

FBD is implemented as a separate toggle in Brave Shields UI:

Screenshots

image

image

UI "nudge" part is moved here -> #31200

@pes10k pes10k added OS/Android Fixes related to Android browser functionality OS/Desktop labels Nov 2, 2022
@pes10k pes10k added privacy privacy/feature User-facing privacy- & security-focused feature work. privacy-pod Feature work for the Privacy & Web Compatibility pod labels Nov 2, 2022
@iefremov iefremov added this to To Do in Ivan's board via automation Jan 11, 2023
@iefremov iefremov moved this from To Do to In Progress in Ivan's board Jan 11, 2023
@goodov
Copy link
Member

goodov commented Apr 5, 2023

@kjozwiak the core part we're about to enable in nightly does this:

Adds a new option to the cookie block policy dropdown in Shields popup and on brave://settings/shields page. PR description has a video: brave/brave-core#16470 (comment)

When this option is selected, website data (cookies, storages) will be removed after 30 seconds the website is closed.

@LaurenWags
Copy link
Member

@brave/qa-team this should be tested at the same time as #30090 / brave/brave-core#18331 since the test plan is the same.

Confirmed via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1687415361386809?thread_ts=1680615454.570509&cid=CHGKGMHDJ.

@kjozwiak kjozwiak added the Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected label Jul 27, 2023
@Uni-verse Uni-verse added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 2, 2023
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.57.8 Chromium: 115.0.5790.75 (Official Build) beta (64-bit)
-- | --
Revision | 77bffd419b7e89d7e666c9695e7fa0d1d0367a99
OS | Windows 11 Version 22H2 (Build 22621.1992)

Case 1 - Before feature being enabled via Griffin - PASSED

  1. Installed 1.57.8
  2. launched Brave
  3. confirmed BraveForgetFirstPartyStorage isn't visible under brave://version
  4. visited github.com in a new tab
  5. clicked Shields icon to open the Shields panel
  6. opened brave://settings/shields
  • Confirmed Forget me when I close this site toggle doesn't appear via the Shields panel
  • Confirmed Forget me when I close this site toggle doesn't appear via brave://settings/shields
step 3 step 5 step 6
image image image

Case 2: After feature being enabled via Griffin - PASSED

  1. continue from Case 1:
  • BraveForgetFirstPartyStorage isn't visible under brave://version
  • Forget me when I close this site toggle doesn't appear via brave://settings/shields
  1. closed and restarted Brave
  2. confirmed BraveForgetFirstPartyStorage:Enabled is shown in brave://version
  3. opened Shields panel in the nytimes.com tab
  4. opened brave://settings/shields
  • Confirmed Forget me when I close this site toggle appears in the Shields panel and is Off by default
  • Confirmed Forget me when I close this site toggle appears in the brave://settings/shields and is Off by default
step 3 step 4 step 5
image image image

Dark theme

shields panel brave://settings/shields
image image

Note: In-depth testing has been done via #30090 (comment) (Test Case 1 - Test Case 2)

@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 3, 2023

Verification PASSED using

Brave | 1.57.8 Chromium: 115.0.5790.75 (Official Build) beta (64-bit)
-- | --
Revision | 77bffd419b7e89d7e666c9695e7fa0d1d0367a99
OS | Windows 11 Version 22H2 (Build 22621.1992)

Case 1 - Before feature being enabled via Griffin - PASSED

  1. Installed 1.57.8
  2. launched Brave
  3. confirmed BraveForgetFirstPartyStorage isn't visible under brave://version
  4. visited github.com in a new tab
  5. clicked Shields icon to open the Shields panel
  6. opened brave://settings/shields
  • Confirmed Forget me when I close this site toggle doesn't appear via the Shields panel
  • Confirmed Forget me when I close this site toggle doesn't appear via brave://settings/shields
step 3 step 5 step 6
image image image

Case 2: After feature being enabled via Griffin - PASSED

  1. continue from Case 1:
  • BraveForgetFirstPartyStorage isn't visible under brave://version
  • Forget me when I close this site toggle doesn't appear via brave://settings/shields
  1. closed and restarted Brave
  2. confirmed BraveForgetFirstPartyStorage:Enabled is shown in brave://version
  3. opened Shields panel in the nytimes.com tab
  4. opened brave://settings/shields
  • Confirmed Forget me when I close this site toggle appears in the Shields panel and is Off by default
  • Confirmed Forget me when I close this site toggle appears in the brave://settings/shields and is Off by default
step 3 step 4 step 5
image image image

Dark theme

shields panel brave://settings/shields
image image

Note: Verified the UI for for Forget me when I close this site mainly. The toggle is available in the Shields panel & in brave://settings/sheids. UI matches to the screenshots mentioned #26465 (comment). Forget me when I close this site functionality works as expected and In-depth testing is done via 30090

@stephendonner
Copy link

Verification PASSED using

Brave | 1.57.36 Chromium: 115.0.5790.171 (Official Build) beta (x86_64)
-- | --
Revision | a4bb683f14dc402f5da13707e13559dc4d5ef08b
OS | macOS Version 14.0 (Build 23A5301h)

Case 1 - Before feature being enabled via Griffin - PASSED

  1. Installed 1.57.36
  2. launched Brave
  3. confirmed BraveForgetFirstPartyStorage isn't visible under brave://version
  4. visited brave.com in a new tab
  5. clicked Shields icon to open the Shields panel
  6. opened brave://settings/shields
  • Confirmed Forget me when I close this site toggle doesn't appear via the Shields panel
  • Confirmed Forget me when I close this site toggle doesn't appear via brave://settings/shields
step 3 step 5 step 6
Screenshot 2023-08-04 at 11 12 26 AM Screenshot 2023-08-04 at 11 13 42 AM Screenshot 2023-08-04 at 11 13 53 AM

Case 2: After feature being enabled via Griffin - PASSED

  1. continue from Case 1:
  • BraveForgetFirstPartyStorage isn't visible under brave://version
  • Forget me when I close this site toggle doesn't appear via brave://settings/shields
  1. closed and restarted Brave
  2. confirmed BraveForgetFirstPartyStorage:Enabled is shown in brave://version
  3. opened Shields panel in the brave.com tab
  4. opened brave://settings/shields
  • Confirmed Forget me when I close this site toggle appears in the Shields panel and is Off by default
  • Confirmed Forget me when I close this site toggle appears in the brave://settings/shields and is Off by default
step 3 step 4 step 5
Screenshot 2023-08-04 at 11 11 53 AM Screenshot 2023-08-04 at 11 14 25 AM Screenshot 2023-08-04 at 11 14 14 AM

Dark theme

Shields panel brave://settings/shields
Screenshot 2023-08-04 at 11 14 46 AM Screenshot 2023-08-04 at 11 15 01 AM

Note: Verified the UI for for Forget me when I close this site mainly. The toggle is available in the Shields panel & in brave://settings/sheids. UI matches to the screenshots mentioned #26465 (comment). Forget me when I close this site functionality works as expected and In-depth testing is done via 30090

@LaurenWags
Copy link
Member

LaurenWags commented Aug 7, 2023

Verified with

Brave	1.57.36 Chromium: 115.0.5790.171 (Official Build) beta (64-bit) 
Revision	a4bb683f14dc402f5da13707e13559dc4d5ef08b
OS	Linux

Case 1 - Before feature being enabled via Griffin - PASSED

  1. Installed 1.57.36
  2. launched Brave
  3. confirmed BraveForgetFirstPartyStorage isn't visible under brave://version
  4. visited brave.com in a new tab
  5. clicked Shields icon to open the Shields panel
  6. opened brave://settings/shields
  • Confirmed Forget me when I close this site toggle doesn't appear via the Shields panel
  • Confirmed Forget me when I close this site toggle doesn't appear via brave://settings/shields
step 3 step 5 step 6
1 2 3

Case 2: After feature being enabled via Griffin - PASSED

  1. continue from Case 1:
  • BraveForgetFirstPartyStorage isn't visible under brave://version
  • Forget me when I close this site toggle doesn't appear via brave://settings/shields
  1. closed and restarted Brave
  2. confirmed BraveForgetFirstPartyStorage:Enabled is shown in brave://version
  3. opened Shields panel in the brave.com tab
  4. opened brave://settings/shields
  • Confirmed Forget me when I close this site toggle appears in the Shields panel and is Off by default
  • Confirmed Forget me when I close this site toggle appears in the brave://settings/shields and is Off by default
step 3 step 4 step 5
1 2 3

Dark theme

Shields panel brave://settings/shields
4 5

Note: Verified the UI for for Forget me when I close this site mainly. The toggle is available in the Shields panel & in brave://settings/sheids. UI matches to the screenshots mentioned #26465 (comment). Forget me when I close this site functionality works as expected and In-depth testing is done via #30090 (comment).

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 5G using version(s):

Brave	1.57.44 Chromium: 116.0.5845.82 (Official Build) (64-bit) 
Revision	109e984111c5152478bf49d266f4e19861c0b63e
OS	Android 13; Build/TP1A.220624.014; 33; REL

Test Case - Enabling BraveForgetFirstPartyStorage in brave://flags

  • Ensured feature is not shown in shields/privacy settings
  • Open brave://flags and Enable First Party Storage Cleanup Support
  • Ensure that feature is enabled in shields/privacy settings
Example Example Example
Screenshot 2023-08-10 at 4 15 53 PM Screenshot 2023-08-10 at 4 18 57 PM Screenshot 2023-08-10 at 4 21 21 PM

Test Case - Enabling BraveForgetFirstPartyStorage (Toggle per site/wait 30s)

Ensure that BraveForgetFirstPartyStorage:Enabled via brave://flags

  • visit https://www.github.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a github.com entry within Site Settings -> All sites
  • visit https://www.gmail.com and log into an account (ensure that the password credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • restart the browser and ensure that you're still logged into both GitHub & Gmail
  • toggle/enable Forget me when I close this site via the shields panel on both websites and close each one
  • wait ~30s after you've closed both Github & Gmail
  • ensure that github.com & google.com have been completely removed from Site Settings -> All sites
  • re-open both Github & Gmail and ensure that you've been logged out (session cookies removed)
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager
Example Example Example
Screenshot 2023-08-10 at 4 21 21 PM Screenshot 2023-08-10 at 4 24 54 PM Screenshot 2023-08-10 at 4 26 17 PM
Screenshot 2023-08-10 at 4 35 51 PM Screenshot 2023-08-10 at 4 35 17 PM Screenshot 2023-08-10 at 4 37 37 PM

Test Case - Enabling BraveForgetFirstPartyStorage (Re-opening website within ~30s)

  • visit https://www.gmail.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • toggle/enable Forget me when I close this site via the shields panel
  • close https://www.gmail.com/ and then quickly re-load the website within ~30s and ensure you're still logged in
  • ran through this using different times. Example: 5s, 10s, 20s (ensured first party storage wasn't removed)
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is removed from Site Settings -> All sites
  • re-open https://www.gmail.com/ and ensure that you're not logged into Gmail
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager
  • Also used other websites like https://www.boardgamegeek.com/ & https://f1tv.formula1.com/.

Test Case - Enabling BraveForgetFirstPartyStorage (Permissions)

  • visit https://talk.brave.com/ and give Brave Talk permissions to both the Microphone & Camera (also add username)
  • ensure that you have a brave.com entry within Site Settings -> All sites
  • ensure that both permissions are appearing under Allowed via Site Settings -> Camera & Microphone
  • when selecting permissions under https://talk.brave.com/, Forever was selected
  • toggle/enable Forget me when I close this site via the shields panel
  • close https://talk.brave.com/ and wait ~30s
  • ensure that the brave.com entry is still present/visible under Site Settings -> All sites
  • ensure that Camera, Microphone & Sound permissions are listed under Permissions
  • can also check via Site Settings -> Camera & Microphone
  • ensure that the Local Storage portion has been removed from brave.com via Site Settings -> All sites
Example Example Example
Screenshot 2023-08-10 at 4 58 00 PM Screenshot 2023-08-10 at 5 03 05 PM Screenshot 2023-08-10 at 5 04 24 PM

Test Case - Enabling BraveForgetFirstPartyStorage (Feature enabled/disabled shields)

  • visit https://www.gmail.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • toggle/enable Forget me when I close this site via the shields panel
  • once Forget me when I close this site has been enable, disable shields on https://www.gmail.com/
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is NOT being removed/cleared
  • ensure that the entry wasn't cleared via Site Settings -> All sites
  • re-enable shields on https://www.gmail.com/ (ensure that Forget me when I close this site is still enabled)
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is removed from Site Settings -> All sites
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager

Test Case - Enabling BraveForgetFirstPartyStorage (Enabling via Settings)

  • enable Forget me when I close this site via Settings - > Brave Shields & privacy
  • visit several websites and ensure that Forget me when I close this site is enabled via the shields panel
  • visit https://www.gmail.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is removed from Site Settings -> All sites
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager
  • Also ensure that if Forget me when I close this site is enabled globally via Settings - > Brave Shields & privacy, the change is inherited by Private/Incognito mode.

Test Case - Enabling BraveForgetFirstPartyStorage (Enabling via Settings and disabling per website)

  • enable Forget me when I close this site via Settings - > Brave Shields & privacy
  • visit several websites and ensure that Forget me when I close this site is enabled via the shields panel
  • visit https://www.gmail.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • visit https://www.github.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a github.com entry within Site Settings -> All sites
  • disable Forget me when I close this site on https://www.gmail.com/ via brave shields (leave it enabled globally)
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is removed from Site Settings -> All sites
  • close https://www.github.com/ and wait ~30s and ensure github.com is NOT removed from Site Settings -> All sites
  • re-open https://www.github.com/ and ensure that you're still logged in and can use the website without issues
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager

Test Case - Enabling BraveForgetFirstPartyStorage (Toggle per site via Private/Incognito)

  • open a Private/Incognito tab
  • visit https://www.github.com/ and log into the website
  • close/re-open the https://www.github.com/ tab and ensure you're still logged in (don't close the Private/Incognito window)
  • toggle/enable Forget me when I close this site on https://www.github.com/ via shields panel
  • wait ~30s after you've closed both Github and re-open the website
  • ensure that you're not logged into GitHub

As mentioned at the beginning of the issue, the following runs through Test Case #2 & Test Case #3 from #30090 (comment).

Test Case from #30090 (comment)

  • visit https://www.gmail.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • enable Forget me when I close this site on https://www.gmail.com/ via the shields panel
  • disable shields on https://www.gmail.com/
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is NOT removed from Site Settings -> All sites
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager
  • The above case is similar to Test Case above that was done above re: enabling the feature via Settings and then disabling it per site via the shields panel and ensuring that FB was not executed/removed cookies/local storage etc..

Test Case from #30090 (comment)

  • visit https://permission.site/ and enable both the Camera & Microphone permissions
  • ensure that until I close this site is selected for both Camera & Microphone
  • close https://permission.site/ and wait ~30s
  • re-open https://permission.site/ and ensure that the permissions have been reset
  • both Camera & Microphone shouldn't be highlighted green (they should have been reset)

@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 11, 2023

Verified on Samsung Galaxy Tab S7 using version(s):

Brave	1.57.44 Chromium: 116.0.5845.82 (Official Build) (64-bit) 
Revision	109e984111c5152478bf49d266f4e19861c0b63e
OS	Android 13; Build/TP1A.220624.014; 33; REL

Test Case - Enabling BraveForgetFirstPartyStorage in brave://flags

  • Ensured feature is not shown in shields/privacy settings
  • Open brave://flags and Enable First Party Storage Cleanup Support
  • Ensure that feature is enabled in shields/privacy settings
Example Example Example
Screenshot 2023-08-11 at 2 28 54 PM Screenshot 2023-08-11 at 2 29 27 PM Screenshot 2023-08-11 at 2 29 37 PM

Test Case - Enabling BraveForgetFirstPartyStorage (Toggle per site/wait 30s)

Ensure that BraveForgetFirstPartyStorage:Enabled via brave://flags

  • visit https://www.github.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a github.com entry within Site Settings -> All sites
  • visit https://www.gmail.com and log into an account (ensure that the password credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • restart the browser and ensure that you're still logged into both GitHub & Gmail
  • toggle/enable Forget me when I close this site via the shields panel on both websites and close each one
  • wait ~30s after you've closed both Github & Gmail
  • ensure that github.com & google.com have been completely removed from Site Settings -> All sites
  • re-open both Github & Gmail and ensure that you've been logged out (session cookies removed)
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager
Example Example Example
Screenshot 2023-08-11 at 2 36 49 PM Screenshot 2023-08-11 at 2 37 15 PM Screenshot 2023-08-11 at 2 55 22 PM

Test Case - Enabling BraveForgetFirstPartyStorage (Re-opening website within ~30s)

  • visit https://www.gmail.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • toggle/enable Forget me when I close this site via the shields panel
  • close https://www.gmail.com/ and then quickly re-load the website within ~30s and ensure you're still logged in
  • ran through this using different times. Example: 5s, 10s, 20s (ensured first party storage wasn't removed)
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is removed from Site Settings -> All sites
  • re-open https://www.gmail.com/ and ensure that you're not logged into Gmail
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager
  • Also used other websites like https://www.boardgamegeek.com/ & https://f1tv.formula1.com/.

Test Case - Enabling BraveForgetFirstPartyStorage (Permissions)

  • visit https://talk.brave.com/ and give Brave Talk permissions to both the Microphone & Camera (also add username)
  • ensure that you have a brave.com entry within Site Settings -> All sites
  • ensure that both permissions are appearing under Allowed via Site Settings -> Camera & Microphone
  • when selecting permissions under https://talk.brave.com/, Forever was selected
  • toggle/enable Forget me when I close this site via the shields panel
  • close https://talk.brave.com/ and wait ~30s
  • ensure that the brave.com entry is still present/visible under Site Settings -> All sites
  • ensure that Camera, Microphone & Sound permissions are listed under Permissions
  • can also check via Site Settings -> Camera & Microphone
  • ensure that the Local Storage portion has been removed from brave.com via Site Settings -> All sites
Example Example
Screenshot 2023-08-11 at 3 29 27 PM Screenshot 2023-08-11 at 3 29 40 PM

Test Case - Enabling BraveForgetFirstPartyStorage (Feature enabled/disabled shields)

  • visit https://www.gmail.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • toggle/enable Forget me when I close this site via the shields panel
  • once Forget me when I close this site has been enable, disable shields on https://www.gmail.com/
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is NOT being removed/cleared
  • ensure that the entry wasn't cleared via Site Settings -> All sites
  • re-enable shields on https://www.gmail.com/ (ensure that Forget me when I close this site is still enabled)
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is removed from Site Settings -> All sites
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager

Test Case - Enabling BraveForgetFirstPartyStorage (Enabling via Settings)

  • enable Forget me when I close this site via Settings - > Brave Shields & privacy
  • visit several websites and ensure that Forget me when I close this site is enabled via the shields panel
  • visit https://www.gmail.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is removed from Site Settings -> All sites
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager
  • Also ensure that if Forget me when I close this site is enabled globally via Settings - > Brave Shields & privacy, the change is inherited by Private/Incognito mode.

Test Case - Enabling BraveForgetFirstPartyStorage (Enabling via Settings and disabling per website)

  • enable Forget me when I close this site via Settings - > Brave Shields & privacy
  • visit several websites and ensure that Forget me when I close this site is enabled via the shields panel
  • visit https://www.gmail.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • visit https://www.github.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a github.com entry within Site Settings -> All sites
  • disable Forget me when I close this site on https://www.gmail.com/ via brave shields (leave it enabled globally)
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is removed from Site Settings -> All sites
  • close https://www.github.com/ and wait ~30s and ensure github.com is NOT removed from Site Settings -> All sites
  • re-open https://www.github.com/ and ensure that you're still logged in and can use the website without issues
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager
search.brave.com (disabled per site) facebook (enabled per settings) Before After
Screenshot 2023-08-11 at 3 42 46 PM Screenshot 2023-08-11 at 3 42 58 PM Screenshot 2023-08-11 at 3 43 14 PM Screenshot 2023-08-11 at 3 44 09 PM

Test Case - Enabling BraveForgetFirstPartyStorage (Toggle per site via Private/Incognito)

  • open a Private/Incognito tab
  • visit https://www.github.com/ and log into the website
  • close/re-open the https://www.github.com/ tab and ensure you're still logged in (don't close the Private/Incognito window)
  • toggle/enable Forget me when I close this site on https://www.github.com/ via shields panel
  • wait ~30s after you've closed both Github and re-open the website
  • ensure that you're not logged into GitHub

As mentioned at the beginning of the issue, the following runs through Test Case #2 & Test Case #3 from #30090 (comment).

Test Case from #30090 (comment)

  • visit https://www.gmail.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • enable Forget me when I close this site on https://www.gmail.com/ via the shields panel
  • disable shields on https://www.gmail.com/
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is NOT removed from Site Settings -> All sites
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager
  • The above case is similar to Test Case above that was done above re: enabling the feature via Settings and then disabling it per site via the shields panel and ensuring that FB was not executed/removed cookies/local storage etc..

Test Case from #30090 (comment)

  • visit https://permission.site/ and enable both the Camera & Microphone permissions
  • ensure that until I close this site is selected for both Camera & Microphone
  • close https://permission.site/ and wait ~30s
  • re-open https://permission.site/ and ensure that the permissions have been reset
  • both Camera & Microphone shouldn't be highlighted green (they should have been reset)
Example Example
Screenshot 2023-08-11 at 3 55 32 PM Screenshot 2023-08-11 at 3 55 20 PM

@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 11, 2023

Verified on Pixel 5 (x86) running Android 8 using version(s):

Brave	1.57.44 Chromium: 116.0.5845.82 (Official Build) (32-bit) 
Revision	109e984111c5152478bf49d266f4e19861c0b63e
OS	Android 8.0.0; Build/OSR1.180418.026; 26; REL

Test Case - Enabling BraveForgetFirstPartyStorage in brave://flags

  • Ensured feature is not shown in shields/privacy settings
  • Open brave://flags and Enable First Party Storage Cleanup Support
  • Ensure that feature is enabled in shields/privacy settings
Example Example
Screenshot 2023-08-11 at 6 29 51 PM Screenshot 2023-08-11 at 6 41 10 PM

Test Case - Enabling BraveForgetFirstPartyStorage (Toggle per site/wait 30s)

Ensure that BraveForgetFirstPartyStorage:Enabled via brave://flags

  • visit https://www.github.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a github.com entry within Site Settings -> All sites
  • visit https://www.gmail.com and log into an account (ensure that the password credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • restart the browser and ensure that you're still logged into both GitHub & Gmail
  • toggle/enable Forget me when I close this site via the shields panel on both websites and close each one
  • wait ~30s after you've closed both Github & Gmail
  • ensure that github.com & google.com have been completely removed from Site Settings -> All sites
  • re-open both Github & Gmail and ensure that you've been logged out (session cookies removed)
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager
Example Example Example
Screenshot 2023-08-11 at 6 39 45 PM Screenshot 2023-08-11 at 6 39 10 PM Screenshot 2023-08-11 at 6 39 31 PM

Test Case - Enabling BraveForgetFirstPartyStorage (Re-opening website within ~30s)

  • visit https://www.gmail.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • toggle/enable Forget me when I close this site via the shields panel
  • close https://www.gmail.com/ and then quickly re-load the website within ~30s and ensure you're still logged in
  • ran through this using different times. Example: 5s, 10s, 20s (ensured first party storage wasn't removed)
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is removed from Site Settings -> All sites
  • re-open https://www.gmail.com/ and ensure that you're not logged into Gmail
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager
  • Also used other websites like https://www.boardgamegeek.com/ & https://f1tv.formula1.com/.

Test Case - Enabling BraveForgetFirstPartyStorage (Permissions)

  • visit https://talk.brave.com/ and give Brave Talk permissions to both the Microphone & Camera (also add username)
  • ensure that you have a brave.com entry within Site Settings -> All sites
  • ensure that both permissions are appearing under Allowed via Site Settings -> Camera & Microphone
  • when selecting permissions under https://talk.brave.com/, Forever was selected
  • toggle/enable Forget me when I close this site via the shields panel
  • close https://talk.brave.com/ and wait ~30s
  • ensure that the brave.com entry is still present/visible under Site Settings -> All sites
  • ensure that Camera, Microphone & Sound permissions are listed under Permissions
  • can also check via Site Settings -> Camera & Microphone
  • ensure that the Local Storage portion has been removed from brave.com via Site Settings -> All sites
Example Example Example
Screenshot 2023-08-11 at 6 44 20 PM Screenshot 2023-08-11 at 6 49 57 PM Screenshot 2023-08-11 at 6 50 26 PM

Test Case - Enabling BraveForgetFirstPartyStorage (Feature enabled/disabled shields)

  • visit https://www.gmail.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • toggle/enable Forget me when I close this site via the shields panel
  • once Forget me when I close this site has been enable, disable shields on https://www.gmail.com/
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is NOT being removed/cleared
  • ensure that the entry wasn't cleared via Site Settings -> All sites
  • re-enable shields on https://www.gmail.com/ (ensure that Forget me when I close this site is still enabled)
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is removed from Site Settings -> All sites
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager

Test Case - Enabling BraveForgetFirstPartyStorage (Enabling via Settings)

  • enable Forget me when I close this site via Settings - > Brave Shields & privacy
  • visit several websites and ensure that Forget me when I close this site is enabled via the shields panel
  • visit https://www.gmail.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is removed from Site Settings -> All sites
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager
  • Also ensure that if Forget me when I close this site is enabled globally via Settings - > Brave Shields & privacy, the change is inherited by Private/Incognito mode.

Test Case - Enabling BraveForgetFirstPartyStorage (Enabling via Settings and disabling per website)

  • enable Forget me when I close this site via Settings - > Brave Shields & privacy
  • visit several websites and ensure that Forget me when I close this site is enabled via the shields panel
  • visit https://www.gmail.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • visit https://www.github.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a github.com entry within Site Settings -> All sites
  • disable Forget me when I close this site on https://www.gmail.com/ via brave shields (leave it enabled globally)
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is removed from Site Settings -> All sites
  • close https://www.github.com/ and wait ~30s and ensure github.com is NOT removed from Site Settings -> All sites
  • re-open https://www.github.com/ and ensure that you're still logged in and can use the website without issues
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager

Test Case - Enabling BraveForgetFirstPartyStorage (Toggle per site via Private/Incognito)

  • open a Private/Incognito tab
  • visit https://www.github.com/ and log into the website
  • close/re-open the https://www.github.com/ tab and ensure you're still logged in (don't close the Private/Incognito window)
  • toggle/enable Forget me when I close this site on https://www.github.com/ via shields panel
  • wait ~30s after you've closed both Github and re-open the website
  • ensure that you're not logged into GitHub

As mentioned at the beginning of the issue, the following runs through Test Case #2 & Test Case #3 from #30090 (comment).

Test Case from #30090 (comment)

  • visit https://www.gmail.com/ and log into the website (ensure that passwords credentials are saved)
  • once you're logged in, ensure that you have a google.com entry within Site Settings -> All sites
  • enable Forget me when I close this site on https://www.gmail.com/ via the shields panel
  • disable shields on https://www.gmail.com/
  • close https://www.gmail.com/ and wait ~30s and ensure google.com is NOT removed from Site Settings -> All sites
  • ensure that Hamburger menu -> History hasn't been removed/cleared
  • ensure that passwords are not being removed via Site Settings -> Password Manager
  • The above case is similar to Test Case above that was done above re: enabling the feature via Settings and then disabling it per site via the shields panel and ensuring that FB was not executed/removed cookies/local storage etc..

Test Case from #30090 (comment)

  • visit https://permission.site/ and enable both the Camera & Microphone permissions
  • ensure that until I close this site is selected for both Camera & Microphone
  • close https://permission.site/ and wait ~30s
  • re-open https://permission.site/ and ensure that the permissions have been reset
  • both Camera & Microphone shouldn't be highlighted green (they should have been reset)

@Bushido1
Copy link

I cannot find the aforementioned feature in the Shields popup of Brave 1.57.53, Chromium: 116.0.5845.114.
I see only this:
image
.

@pjolt
Copy link

pjolt commented Aug 24, 2023

I cannot find the aforementioned feature in the Shields popup of Brave 1.57.53, Chromium: 116.0.5845.114. I see only this: image .

See #32311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/shields/forgetful-browsing OS/Android Fixes related to Android browser functionality OS/Desktop privacy/feature User-facing privacy- & security-focused feature work. privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA Pass - Android 8+ QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Development

No branches or pull requests

10 participants