Add support for first party storage removal on website close. #16470

goodov · 2022-12-23T10:44:51Z

Forget by default option is implemented as "Block cross-site cookies" + logic to delete cookies on website close.

The availability of the new mode is controlled by Enable First Party Storage Cleanup support on brave://flags or --enable-feature=BraveForgetFirstPartyStorage.

This PR doesn't change the "default" state for the shields cookie policy if the feature is enabled (it's still "Block cross-site cookies").

Spec: https://docs.google.com/document/d/1TeDqwnKqOJqSv0b80liZjAFR1BUPc6urGkkHiHN526s/

4cpjfSluSp.mp4

Core part for brave/brave-browser#26465

Submitter Checklist:

I confirm that no security/privacy review is needed, or that I have requested one
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally:
- npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
- npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

brave-builds · 2022-12-23T15:21:57Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-01-09T09:26:22Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-01-11T15:32:44Z

A Storybook has been deployed to preview UI for the latest push

pes10k · 2023-01-11T15:48:33Z

This looks great @goodov, but i don't think it fully resolves brave/brave-browser#26465. We still need the second point in #26465 before we close #26465 out.

Brave should give users a convenient way to “opt-into” a site remembering them (instead of making it the default)

Never the less, this is great stuff!

goodov · 2023-01-11T15:51:58Z

This looks great @goodov, but i don't think it fully resolves brave/brave-browser#26465. We still need the second point in #26465 before we close #26465 out.

Brave should give users a convenient way to “opt-into” a site remembering them (instead of making it the default)

yes, definitely! I've removed "Resolves" keyword from the description.

Can you take a look at the UI strings and maybe suggest some changes (if any)?

pes10k · 2023-01-11T15:53:48Z

@bradleyrichter wanted to ping you and your team on the wording here. We started discussing this a while back, but i dont think the design team landed on final text you all preferred. What do you all think is the ideal label here for what's called "Forget by default" in the video?

brave-builds · 2023-01-16T15:48:50Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-01-31T18:11:31Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-02-01T13:57:51Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-02-01T15:49:50Z

A Storybook has been deployed to preview UI for the latest push

iefremov · 2023-03-16T16:36:13Z

browser/ephemeral_storage/ephemeral_storage_tab_helper.cc

-  if (new_domain == previous_domain)
-    return;
+      net::URLToEphemeralStorageDomain(last_committed_url);
+  if (new_domain != previous_domain) {


a couple of lines of comments wouldn't hurt

iefremov · 2023-03-16T16:36:29Z

browser/ephemeral_storage/first_party_storage_lifetime.h

+using FirstPartyStorageLifetimeKey =
+    std::pair<content::BrowserContext*, url::Origin>;
+
+class FirstPartyStorageLifetime


class level comment?

iefremov · 2023-03-16T16:37:09Z

components/ephemeral_storage/ephemeral_storage_pref_names.cc

+
+namespace ephemeral_storage {
+
+const char kFirstPartyStorageURLsToCleanup[] =


iefremov · 2023-03-16T16:37:36Z

components/ephemeral_storage/ephemeral_storage_service.h

 private:
  void OnCanEnable1PESForUrl(const GURL& url,
                             base::OnceCallback<void(bool)> on_ready,
                             bool can_enable_1pes);
  bool IsDefaultCookieSetting(const GURL& url) const;

+  void CleanupFirstPartyStorageAreasOnStartup();


comments, i.e. why / what for this is needed and used

browser/ui/brave_shields_data_controller.cc

goodov · 2023-03-20T13:11:05Z

@brave/android-tests-reviewers PTAL

wchen342

lgtm

goodov requested a review from a team as a code owner December 23, 2022 10:44

github-actions bot assigned goodov Dec 23, 2022

github-actions bot added CI/run-network-audit Run network-audit CI/storybook-url Deploy storybook and provide a unique URL for each build labels Dec 23, 2022

goodov marked this pull request as draft December 23, 2022 10:49

goodov added the CI/run-draft label Dec 23, 2022

goodov force-pushed the forget-by-default branch 2 times, most recently from 328f8db to f89d283 Compare December 23, 2022 14:28

goodov force-pushed the forget-by-default branch from f89d283 to 05a1ff2 Compare January 9, 2023 08:28

goodov marked this pull request as ready for review January 11, 2023 13:26

goodov requested review from pes10k and iefremov January 11, 2023 13:26

goodov force-pushed the forget-by-default branch from 05a1ff2 to d17fbed Compare January 11, 2023 14:38

goodov force-pushed the forget-by-default branch from d17fbed to 79e7485 Compare January 16, 2023 14:29

goodov force-pushed the forget-by-default branch from 79e7485 to a1db8d6 Compare January 31, 2023 16:49

goodov force-pushed the forget-by-default branch 2 times, most recently from 60d9782 to da3e16f Compare February 1, 2023 13:05

goodov force-pushed the forget-by-default branch from da3e16f to ddc3fba Compare February 1, 2023 15:09

goodov force-pushed the forget-by-default branch from ddc3fba to 4bd207b Compare February 1, 2023 16:46

goodov requested a review from a team as a code owner February 1, 2023 16:46

mihaiplesa removed the CI/run-draft label Mar 7, 2023

goodov force-pushed the forget-by-default branch from 112bbf1 to 0e3d310 Compare March 13, 2023 11:50

goodov requested a review from a team as a code owner March 13, 2023 11:50

iefremov reviewed Mar 16, 2023

View reviewed changes

iefremov approved these changes Mar 16, 2023

View reviewed changes

goodov force-pushed the forget-by-default branch from 0e3d310 to 04f2002 Compare March 17, 2023 15:37

github-actions bot reviewed Mar 17, 2023

View reviewed changes

browser/ui/brave_shields_data_controller.cc Show resolved Hide resolved

browser/ui/brave_shields_data_controller.cc Show resolved Hide resolved

github-actions bot added the needs-security-review label Mar 17, 2023

github-actions bot assigned fmarier and thypon Mar 17, 2023

goodov added 3 commits March 20, 2023 13:32

Add support for first party storage removal on website close.

ab7cf43

Add tests, fix few issues.

cdc9b5b

Add few comments, rename pref to better reflect the actual content.

48aadd6

goodov force-pushed the forget-by-default branch from 04f2002 to 48aadd6 Compare March 20, 2023 06:32

thypon mentioned this pull request Mar 20, 2023

Ruleset for https://github.com/0xdea/semgrep-rules/blob/main/c/missing-default-in-switch.yaml not required in brave-core brave/security-action#144

Closed

2 tasks

thypon removed the needs-security-review label Mar 20, 2023

thypon removed their assignment Mar 20, 2023

wchen342 approved these changes Mar 21, 2023

View reviewed changes

goodov merged commit 708de7a into master Mar 21, 2023

goodov deleted the forget-by-default branch March 21, 2023 14:52

github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 21, 2023

github-actions bot added this to the 1.51.x - Nightly milestone Mar 21, 2023

This was referenced Mar 23, 2023

Enable BraveForgetFirstPartyStorage on nightly desktop. brave/brave-variations#567

Merged

Enable BraveForgetFirstPartyStorage on nightly desktop. brave/brave-variations#571

Merged

goodov mentioned this pull request Apr 5, 2023

"Forget By Default" feature brave/brave-browser#26465

Closed

goodov mentioned this pull request May 2, 2023

[FBD] Synchronize ephemeral and first party storage cleanup event brave/brave-browser#30090

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for first party storage removal on website close. #16470

Add support for first party storage removal on website close. #16470

goodov commented Dec 23, 2022 •

edited

Loading

brave-builds commented Dec 23, 2022

brave-builds commented Jan 9, 2023

brave-builds commented Jan 11, 2023

pes10k commented Jan 11, 2023

goodov commented Jan 11, 2023 •

edited

Loading

pes10k commented Jan 11, 2023

brave-builds commented Jan 16, 2023

brave-builds commented Jan 31, 2023

brave-builds commented Feb 1, 2023

brave-builds commented Feb 1, 2023

iefremov Mar 16, 2023

iefremov Mar 16, 2023

iefremov Mar 16, 2023

iefremov Mar 16, 2023

goodov commented Mar 20, 2023

wchen342 left a comment


		namespace ephemeral_storage {

		const char kFirstPartyStorageURLsToCleanup[] =

Add support for first party storage removal on website close. #16470

Add support for first party storage removal on website close. #16470

Conversation

goodov commented Dec 23, 2022 • edited Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

brave-builds commented Dec 23, 2022

brave-builds commented Jan 9, 2023

brave-builds commented Jan 11, 2023

pes10k commented Jan 11, 2023

goodov commented Jan 11, 2023 • edited Loading

pes10k commented Jan 11, 2023

brave-builds commented Jan 16, 2023

brave-builds commented Jan 31, 2023

brave-builds commented Feb 1, 2023

brave-builds commented Feb 1, 2023

iefremov Mar 16, 2023

Choose a reason for hiding this comment

iefremov Mar 16, 2023

Choose a reason for hiding this comment

iefremov Mar 16, 2023

Choose a reason for hiding this comment

iefremov Mar 16, 2023

Choose a reason for hiding this comment

goodov commented Mar 20, 2023

wchen342 left a comment

Choose a reason for hiding this comment

goodov commented Dec 23, 2022 •

edited

Loading

goodov commented Jan 11, 2023 •

edited

Loading