Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News]: Add translations & icons for new Channels. #27024

Closed
fallaciousreasoning opened this issue Nov 29, 2022 · 5 comments · Fixed by brave/brave-core#16148
Closed

[Brave News]: Add translations & icons for new Channels. #27024

fallaciousreasoning opened this issue Nov 29, 2022 · 5 comments · Fixed by brave/brave-core#16148
Assignees
Labels
feature/brave-news formerly brave-today l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/exclude

Comments

@fallaciousreasoning
Copy link

fallaciousreasoning commented Nov 29, 2022

The Brave News backend has added some new channels (Music, Tech News, Tech Reviews & more). We should add translations for these new channels and also some new icons.

Thanks @aurangzaib048 for raising this!

@aguscruiz do you know if we have icons for these new channels?

@aguscruiz
Copy link

I added the new channel icons here: https://www.figma.com/file/SDcE22eeUsV2uc4dy3NwaC/Desktop-News---Onboarding?node-id=740%3A67478&t=vhDSgWnpqXnw0PbI-1

Let me know if we're missing any

@rebron rebron added l10n priority/P2 A bad problem. We might uplift this to the next planned release. feature/brave-news formerly brave-today labels Nov 29, 2022
@fallaciousreasoning
Copy link
Author

New channels as best I can tell are:

  • Entertainment News
  • Film and TV
  • Music
  • Regional News
  • Tech News
  • Tech Reviews
  • US News

I think we missed Entertainment News, but I'm just going to reuse the entertainment icon.

@mattmcalister
Copy link

mattmcalister commented Nov 29, 2022

The complete list (at the moment) -- new channel names in bold:

  • Brave
  • Business
  • Cars
  • Crypto
  • Culture
  • Entertainment News
  • Fashion
  • Film and TV
  • Food
  • Fun
  • Gaming
  • Health
  • Home
  • Music
  • Politics
  • Science
  • Sports
  • Tech News
  • Tech Reviews
  • Top News
  • Top Sources
  • Travel
  • US News
  • Weather
  • World News

@kjozwiak
Copy link
Member

kjozwiak commented Dec 8, 2022

The above requires 1.47.120 or higher for 1.47.x verification 👍

@stephendonner
Copy link

stephendonner commented Dec 9, 2022

Verified PASSED using

Brave 1.47.120 Chromium: 108.0.5359.99 (Official Build) dev (x86_64)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS macOS Version 13.1 (Build 22C65)

Steps:

  1. installed 1.47.120
  2. changed my OS language to [Spanish, Greek, German]
  3. launched Brave
  4. opened a new-tab page
  5. scrolled down
  6. clicked on Show Brave News
  7. clicked Customize
  8. scrolled down and examined the (translated) channel names and icons

Confirmed the beginnings of the newly translated strings were there across Spanish, Greek, and German locales

Spanish Greek German
Captura de pantalla 2022-12-08 a la(s) 8 06 32 p m Στιγμιότυπο οθόνης 2022-12-08, 8 17 27 μμ Bildschirm­foto 2022-12-08 um 8 59 37 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/brave-news formerly brave-today l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants