Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache wallet transaction data within the walletApi Redux slice #27869

Closed
josheleonard opened this issue Jan 17, 2023 · 1 comment · Fixed by brave/brave-core#16711
Closed

cache wallet transaction data within the walletApi Redux slice #27869

josheleonard opened this issue Jan 17, 2023 · 1 comment · Fixed by brave/brave-core#16711
Assignees
@josheleonard
Labels
dev-concern feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop perf QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@josheleonard
Copy link

josheleonard commented Jan 17, 2023 •
edited
Loading

Description

Caching the transaction data will prevent unneeded lookups from core.
Provide mutations in order to update the invalidate when needed.
@josheleonard josheleonard self-assigned this Jan 17, 2023
@josheleonard josheleonard moved this to In Progress in Web3 Jan 17, 2023
@josheleonard josheleonard mentioned this issue Jan 17, 2023
Merged
25 tasks
@josheleonard josheleonard moved this from In Progress to In Review in Web3 Jan 18, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jan 21, 2023
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 21, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16711
  • Verified wallet transactions work as expected
  • Verified swaps work fine as expected

@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
dev-concern feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop perf QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

feat: cache account transaction data brave/brave-core
3 participants
@srirambv @josheleonard @brave-builds