Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Occasionally, Brave News will not peek on NTP #28018

Closed
petemill opened this issue Jan 24, 2023 · 1 comment · Fixed by brave/brave-core#16757
Closed

[Desktop] Occasionally, Brave News will not peek on NTP #28018

petemill opened this issue Jan 24, 2023 · 1 comment · Fixed by brave/brave-core#16757

Comments

@petemill
Copy link
Member

Description

Occasionally, Brave News will not peek on NTP

Steps to Reproduce

  1. Ensure Brave news is Enabled
  2. Open NTP
  3. Wait 3 seconds
    (refresh if problem does not reproduce, it should happen at least once within 5 NTP refreshes)

Actual result:

Brave News does not peek

Expected result:

Brave News peeks up

Reproduces how often:

Sometimes 100%, sometimes 25%

Brave version (brave://version info)

1.49.52

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes
@stephendonner
Copy link

stephendonner commented Feb 8, 2023

Verification IN-PROGRESS using

Brave 1.49.89 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Reproduced the issue using 1.49.52: (very intermittent, as noted)

not peeking peeking peeking
Screen Shot 2023-02-07 at 4 56 35 PM Screen Shot 2023-02-07 at 4 56 57 PM Screen Shot 2023-02-07 at 4 57 15 PM

Confirmed the fix using 1.49.89:

brave-news-peeking

Tried the following to break it:

  • interrupting the auto-peek via Reload button or scrolling the viewport up and down
  • shift + reload
  • opening successive new tabs/windows
  • alternating tabs/windows
  • etc.

In all cases so far, it returns to auto-scroll, as it should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment