Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ad blocking aggressive mode for search result ad #28253

Closed
aseren opened this issue Feb 2, 2023 · 1 comment · Fixed by brave/brave-core#17257
Closed

Support ad blocking aggressive mode for search result ad #28253

aseren opened this issue Feb 2, 2023 · 1 comment · Fixed by brave/brave-core#17257
Assignees
@aseren
Labels
Brave Search feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.50.x - Release

Comments

@aseren
Copy link

aseren commented Feb 2, 2023 •
edited
Loading

Discussion thread: https://bravesoftware.slack.com/archives/C01NNFM9XMM/p1674594532142009
@aseren aseren self-assigned this Feb 2, 2023
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. Brave Search labels Feb 3, 2023
@aseren aseren mentioned this issue Feb 14, 2023
Closed
25 tasks
@aseren aseren mentioned this issue Feb 16, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 21, 2023
@btlechowski
Copy link

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Ubuntu 18.04 LTS

Block Ads and trackers - default setting

Verified ad is delivered, served, viewed and confirmed

[19857:19857:0403/144413.639925:VERBOSE6:search_result_ad_converting_util.cc(315)] A search result ad was delivered:
  "data-placement-id": f12feb43-5f04-4606-878b-1aa93468f1ad
  "data-creative-instance-id": bedc80cf-ae56-49f0-818d-a824cc8ac081
  "data-creative-set-id": 54b142f8-ac8a-4439-b1ad-eedc53961dab
  "data-campaign-id": b819e1cf-2f76-473e-8323-5d01ad13852d
  "data-advertiser-id": 735a260f-45d5-4b29-b2f0-9918e910f0ae
  "data-landing-page": https://shop.ledger.com/?r=0ba5d7199327&tracker=search
  "data-headline-text": Ledger: Hardware Wallet
  "data-description": Tus necesidades cripto, de forma segura
  "data-rewards-value": 0
[19857:19857:0403/144413.645077:VERBOSE2:tab_manager.cc(156)] Tab id 1317214125 HTML content changed
[19857:19857:0403/144413.672418:VERBOSE1:conversions.cc(281)] Checking URL for conversions
[19857:19857:0403/144413.676558:VERBOSE2:tab_manager.cc(140)] Tab id 1317214125 text content changed
[19857:19857:0403/144413.809439:VERBOSE1:purchase_intent_processor.cc(102)] No purchase intent matches found for visited URL
[19857:19857:0403/144413.845048:VERBOSE1:text_classification_processor.cc(76)] Classified text with the top segment as travel-travel
[19857:19857:0403/144413.913116:VERBOSE3:search_result_ad_event_served.cc(19)] Served search result ad with placement id f12feb43-5f04-4606-878b-1aa93468f1ad and creative instance id bedc80cf-ae56-49f0-818d-a824cc8ac081
[19857:19857:0403/144413.927952:VERBOSE6:search_result_ad_event_served.cc(28)] Successfully logged search result ad served event
[19857:19857:0403/144413.942112:VERBOSE3:search_result_ad_event_handler.cc(176)] Successfully saved deposits state
[19857:19857:0403/144413.942395:VERBOSE3:search_result_ad_event_handler.cc(199)] Successfully saved conversions state
[19857:19857:0403/144413.942750:VERBOSE1:conversions.cc(362)] There were no conversion matches
[19857:19857:0403/144413.951966:VERBOSE3:search_result_ad_event_viewed.cc(19)] Viewed search result ad with placement id f12feb43-5f04-4606-878b-1aa93468f1ad and creative instance id bedc80cf-ae56-49f0-818d-a824cc8ac081
[19857:19857:0403/144413.976991:VERBOSE6:search_result_ad_event_viewed.cc(28)] Successfully logged search result ad viewed event
[19857:19857:0403/144413.996230:VERBOSE3:account.cc(202)] Successfully processed deposit for search_result_ad with creative instance id bedc80cf-ae56-49f0-818d-a824cc8ac081 and view valued at 0
[19857:19857:0403/144413.996874:VERBOSE1:confirmations.cc(92)] Confirming view for search_result_ad with transaction id 07437129-29a8-4be8-b134-375e6a36cc89 and creative instance id bedc80cf-ae56-49f0-818d-a824cc8ac081

Aggressively block Ads and trackers from Brave shields Panel

Verified ad is delivered, but not served nor viewed nor confirmed

[19857:19857:0403/145808.318588:VERBOSE6:search_result_ad_converting_util.cc(315)] A search result ad was delivered:
  "data-placement-id": d84d2c97-14b9-4114-8580-4996d502add3
  "data-creative-instance-id": b5aaf1a3-4446-4bec-9390-c940e6616560
  "data-creative-set-id": dcbb167c-c667-48fe-acfb-d14a109022f7
  "data-campaign-id": 1d130998-b5ef-4258-8c96-5cf58b80f647
  "data-advertiser-id": 735a260f-45d5-4b29-b2f0-9918e910f0ae
  "data-landing-page": https://med.etoro.com/aw.aspx?B=20017&A=84346&Task=Click&SubAffiliateID=352042739
  "data-headline-text": Join Over 30M Users on eToro™
  "data-description": Discover Opportunities in Local & Global Markets. 79% of Retail CFD Accounts Lose Money
  "data-rewards-value": 0
[19857:19857:0403/145808.335700:VERBOSE2:tab_manager.cc(156)] Tab id 1317214125 HTML content changed
[19857:19857:0403/145808.337297:VERBOSE1:conversions.cc(281)] Checking URL for conversions
[19857:19857:0403/145808.338298:VERBOSE2:tab_manager.cc(140)] Tab id 1317214125 text content changed

Aggressively block Ads and trackers from settings

Verified ad is delivered, but not served nor viewed nor confirmed

[20466:20466:0403/151907.946092:VERBOSE6:search_result_ad_converting_util.cc(315)] A search result ad was delivered:
  "data-placement-id": 9310e056-14b0-45d3-8379-6934cea550be
  "data-creative-instance-id": 76cf4dec-988b-440d-b958-fdfac688f69c
  "data-creative-set-id": 3000c8d1-ccdd-4498-bd22-cccd212cbae5
  "data-campaign-id": 7d28bebf-ecab-4480-bbc7-597587941ed0
  "data-advertiser-id": d9ac92c8-061b-4800-a9b8-ed5e54c0615a
  "data-landing-page": https://polkadot.network/staking/?utm_source=brave&utm_medium=cpc&utm_campaign=staking&utm_content=generic&utm_term=1
  "data-headline-text": Staking has never been easier
  "data-description": Stake DOT natively and collect rewards for helping secure the Polkadot network.
  "data-rewards-value": 0
[20466:20466:0403/151908.009102:VERBOSE2:tab_manager.cc(96)] Tab id 923365601 was updated
[20466:20466:0403/151908.060892:VERBOSE6:user_activity_manager.cc(49)] Triggered event: 11 (0:0:900 s)
[20466:20466:0403/151908.065290:VERBOSE2:tab_manager.cc(156)] Tab id 923365601 HTML content changed
[20466:20466:0403/151908.066847:VERBOSE1:conversions.cc(281)] Checking URL for conversions
[20466:20466:0403/151908.067195:VERBOSE2:tab_manager.cc(140)] Tab id 923365601 text content changed
[20466:20466:0403/151908.068085:VERBOSE1:purchase_intent_processor.cc(102)] No purchase intent matches found for visited URL
[20466:20466:0403/151908.099731:VERBOSE1:text_classification_processor.cc(76)] Classified text with the top segment as travel-travel
[20466:20466:0403/151908.168686:VERBOSE1:conversions.cc(362)] There were no conversion matches
[20466:20466:0403/151910.625980:VERBOSE1:browser_manager.cc(120)] Browser did resign active
[20466:20466:0403/151910.627753:VERBOSE6:user_activity_manager.cc(49)] Triggered event: 17 (0:0:900 s)
[20466:20466:0403/151910.657138:VERBOSE1:browser_manager.cc(140)] Browser did enter background
[20466:20466:0403/151910.657138:VERBOSE6:user_activity_manager.cc(49)] Triggered event: 02 (0:0:900 s)

Block Ads and trackers - shields down

Verified ad is delivered, served, viewed and confirmed

[20466:20466:0403/151943.435402:VERBOSE6:search_result_ad_converting_util.cc(315)] A search result ad was delivered:
  "data-placement-id": 164b380b-9207-4b69-80b3-89b5cddcb9d8
  "data-creative-instance-id": 014f6a66-1552-41d4-aa8a-0be7b3ce10b0
  "data-creative-set-id": e8f8fea3-f657-485d-b5ca-a85305d07cda
  "data-campaign-id": db059451-9227-4e9f-8906-ab0c686e1332
  "data-advertiser-id": 735a260f-45d5-4b29-b2f0-9918e910f0ae
  "data-landing-page": https://med.etoro.com/aw.aspx?B=20017&A=84346&Task=Click&SubAffiliateID=352042739
  "data-headline-text": Invest Online on eToro™
  "data-description": Online Trading Available 24/7 on Mobile & Desktop. Capital at risk. See PDS and TMD
  "data-rewards-value": 0
[20466:20466:0403/151943.511464:VERBOSE1:purchase_intent_processor.cc(102)] No purchase intent matches found for visited URL
[20466:20466:0403/151943.591102:VERBOSE1:text_classification_processor.cc(76)] Classified text with the top segment as travel-travel
[20466:20466:0403/151943.716076:VERBOSE3:search_result_ad_event_served.cc(19)] Served search result ad with placement id 164b380b-9207-4b69-80b3-89b5cddcb9d8 and creative instance id 014f6a66-1552-41d4-aa8a-0be7b3ce10b0
[20466:20466:0403/151943.717390:VERBOSE1:conversions.cc(362)] There were no conversion matches
[20466:20466:0403/151943.739511:VERBOSE6:search_result_ad_event_served.cc(28)] Successfully logged search result ad served event
[20466:20466:0403/151943.750775:VERBOSE3:search_result_ad_event_handler.cc(176)] Successfully saved deposits state
[20466:20466:0403/151943.750892:VERBOSE3:search_result_ad_event_handler.cc(199)] Successfully saved conversions state
[20466:20466:0403/151943.752483:VERBOSE3:search_result_ad_event_viewed.cc(19)] Viewed search result ad with placement id 164b380b-9207-4b69-80b3-89b5cddcb9d8 and creative instance id 014f6a66-1552-41d4-aa8a-0be7b3ce10b0
[20466:20466:0403/151943.774688:VERBOSE6:search_result_ad_event_viewed.cc(28)] Successfully logged search result ad viewed event
[20466:20466:0403/151943.796424:VERBOSE3:account.cc(202)] Successfully processed deposit for search_result_ad with creative instance id 014f6a66-1552-41d4-aa8a-0be7b3ce10b0 and view valued at 0
[20466:20466:0403/151943.796644:VERBOSE1:confirmations.cc(92)] Confirming view for search_result_ad with transaction id f81e33a0-4153-4f5d-954e-3aab67a440cf and creative instance id 014f6a66-1552-41d4-aa8a-0be7b3ce10b0

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
Brave Search feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.50.x - Release
5 participants
@rebron @LaurenWags @btlechowski @brave-builds @aseren