Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show swap button on AssetDetails in stacked view #28914

Closed
Pavneet-Sing opened this issue Mar 6, 2023 · 2 comments · Fixed by brave/brave-core#17540
Closed

Show swap button on AssetDetails in stacked view #28914

Pavneet-Sing opened this issue Mar 6, 2023 · 2 comments · Fixed by brave/brave-core#17540
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-macOS-arm64 QA/Yes release-notes/include
Milestone
1.49.x - Release #3

Comments

@Pavneet-Sing
Copy link

Expected result

Screenshot from 2023-03-03 12-11-39
@Pavneet-Sing Pavneet-Sing added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Mar 6, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Mar 6, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Mar 9, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 10, 2023
This was referenced Mar 10, 2023
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.49.124 or higher for 1.49.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.49.126 x64 build

  • Verified steps from brave/brave-core#17540
  • Verified Swap button is shown on Ethereum network for supported tokens
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
28914-ARM.mp4
28914-Tab.mp4

This was referenced Mar 23, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-macOS-arm64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49.x - Release #3
Development

Successfully merging a pull request may close this issue.

fix(wallet): Show correct balance and asset brave/brave-core
4 participants
@kjozwiak @Pavneet-Sing @srirambv @brave-builds