Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on DApps dialogs on Android 8 #29538

Closed
SergeyZhukovsky opened this issue Apr 5, 2023 · 2 comments · Fixed by brave/brave-core#17950
Closed

Crash on DApps dialogs on Android 8 #29538

SergeyZhukovsky opened this issue Apr 5, 2023 · 2 comments · Fixed by brave/brave-core#17950
Assignees
@SergeyZhukovsky
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/web3/wallet/dapps OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Milestone
1.50.x - Release #4

Comments

@SergeyZhukovsky
Copy link
Member

That issue was originally discovered by @vadimstruts and has such a crash stack. It exists in the current 1.49.132 stable.

2023-04-05 15:08:34.901  5064-5064  AndroidRuntime          com.brave.browser_default            E  FATAL EXCEPTION: main
                                                                                                    Process: com.brave.browser_default, PID: 5064
                                                                                                    java.lang.RuntimeException: Unable to start activity ComponentInfo{com.brave.browser_default/org.chromium.chrome.browser.crypto_wallet.activities.BraveWalletDAppsActivity}: java.lang.IllegalStateException: Only fullscreen opaque activities can request orientation
                                                                                                    	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2817)
                                                                                                    	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2892)
                                                                                                    	at android.app.ActivityThread.-wrap11(Unknown Source:0)
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1593)
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:105)
                                                                                                    	at android.os.Looper.loop(Looper.java:164)
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:6541)
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method)
                                                                                                    	at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)
                                                                                                    Caused by: java.lang.IllegalStateException: Only fullscreen opaque activities can request orientation
                                                                                                    	at android.app.Activity.onCreate(Activity.java:986)
                                                                                                    	at androidx.core.app.ComponentActivity.onCreate(ComponentActivity.java:88)
                                                                                                    	at androidx.activity.ComponentActivity.onCreate(ComponentActivity.java:378)
                                                                                                    	at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:216)
                                                                                                    	at org.chromium.chrome.browser.ChromeBaseAppCompatActivity.onCreate(ChromeBaseAppCompatActivity.java:97)
                                                                                                    	at org.chromium.chrome.browser.init.AsyncInitializationActivity.onCreateInternal(AsyncInitializationActivity.java:361)
                                                                                                    	at org.chromium.chrome.browser.init.AsyncInitializationActivity.onCreate(AsyncInitializationActivity.java:301)
                                                                                                    	at android.app.Activity.performCreate(Activity.java:6975)
                                                                                                    	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1213)
                                                                                                    	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2770)
                                                                                                    	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2892) 
                                                                                                    	at android.app.ActivityThread.-wrap11(Unknown Source:0) 
                                                                                                    	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1593) 
                                                                                                    	at android.os.Handler.dispatchMessage(Handler.java:105) 
                                                                                                    	at android.os.Looper.loop(Looper.java:164) 
                                                                                                    	at android.app.ActivityThread.main(ActivityThread.java:6541) 
                                                                                                    	at java.lang.reflect.Method.invoke(Native Method) 
                                                                                                    	at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240) 
                                                                                                    	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767) 

Steps:

  1. Create a wallet.
  2. Go to app.uniswap.org.
  3. Connect a wallet through the website and try to pick a different network there.
@SergeyZhukovsky SergeyZhukovsky added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality feature/web3/wallet/dapps labels Apr 5, 2023
@SergeyZhukovsky SergeyZhukovsky self-assigned this Apr 5, 2023
@SergeyZhukovsky SergeyZhukovsky mentioned this issue Apr 6, 2023
Merged
25 tasks
@SergeyZhukovsky SergeyZhukovsky added this to the 1.52.x - Nightly milestone Apr 6, 2023
This was referenced Apr 6, 2023
Merged
Merged
@SergeyZhukovsky SergeyZhukovsky added the Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected label Apr 6, 2023
@kjozwiak
Copy link
Member

The above requires 1.50.118 or higher for 1.50.x verification 👍

@kjozwiak
Copy link
Member

Going to label this one as QA/No as @srirambv verified the above via #29655 (comment) 👍

@kjozwiak kjozwiak added QA/No and removed QA/Yes labels Apr 19, 2023
@kjozwiak kjozwiak mentioned this issue Apr 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SergeyZhukovsky SergeyZhukovsky

Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/web3/wallet/dapps OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Projects
Web3
Archived in project
Milestone
1.50.x - Release #4
Development

Successfully merging a pull request may close this issue.

Makes a workaround to avoid crash on Android 8 with windowIsTranslucent attr brave/brave-core
3 participants
@kjozwiak @SergeyZhukovsky @brave-builds