Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty state to Portfolio when filters are applied #31147

Closed
StephenHeaps opened this issue Jun 19, 2023 · 1 comment · Fixed by brave/brave-core#19308
Closed

Add empty state to Portfolio when filters are applied #31147

StephenHeaps opened this issue Jun 19, 2023 · 1 comment · Fixed by brave/brave-core#19308
Assignees
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@StephenHeaps
Copy link

Description

Add an empty state to Portfolio when no assets are displayed. This can occur with a combination of the Group By and deselecting all accounts / networks.

Discussion:
https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1686939237810999

Steps to Reproduce

  1. Open Portfolio and tap the filters button
  2. In Filters and display settings, set Group by to None or Networks
  3. Deselect all networks
  4. Tap save changes
  5. Observe no assets show, no empty state
  6. Tap the filters button in Portfolio
  7. In Filters and display settings, set Group by to Accounts
  8. Deselect all accounts
  9. Tap save changes
  10. Observe no assets show, no empty state

Actual result:

empty

Expected result:

Empty state tbd

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version 1.54.70 Chromium: 114.0.5735.133 (Official Build) nightly (arm64)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@StephenHeaps StephenHeaps added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jun 19, 2023
@HEagle18 HEagle18 added the priority/P4 Planned work. We expect to get to it "soon". label Jun 23, 2023
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 19, 2023
@srirambv
Copy link
Contributor

srirambv commented Sep 4, 2023

Verification passed on

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build) beta (64-bit)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS Linux
  • Verified steps from brave/brave-core#19308
  • Verified Empty Token List is shown when all network/accounts is disabled in Portfolio settings
  • Verified other call to actions (Buy/Send/Swap/Market) work as expected
31147.mp4

Verification passed on

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build)) beta (64-bit)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS Windows 11 Version 22H2 (Build 22621.2215)
  • Verified steps from brave/brave-core#19308
  • Verified Empty Token List is shown when all network/accounts is disabled in Portfolio settings
  • Verified other call to actions (Buy/Send/Swap/Market) work as expected
31147.mp4

Verification passed on

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build) beta (arm64)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS macOS Version 13.4.1 (c) (Build 22F770820d)
  • Verified steps from brave/brave-core#19308
  • Verified Empty Token List is shown when all network/accounts is disabled in Portfolio settings
  • Verified other call to actions (Buy/Send/Swap/Market) work as expected
31147.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants