Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on v1.56.9, Assets manually added don't get added to deposit list #31889

Closed
HEagle18 opened this issue Jul 26, 2023 · 3 comments · Fixed by brave/brave-core#19702
Closed

on v1.56.9, Assets manually added don't get added to deposit list #31889

HEagle18 opened this issue Jul 26, 2023 · 3 comments · Fixed by brave/brave-core#19702
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include

Comments

@HEagle18
Copy link

Description

See thread here - > https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1690382104488839

User brought it up here - > https://community.brave.com/t/please-add-plu-pluton-support/495588/5

Steps to Reproduce

  1. try to add a token manually
  2. then try see if its on deposit list

Actual result:

Screen.Recording.2023-07-26.at.16.43.38.mov

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@HEagle18 HEagle18 added bug OS/Android Fixes related to Android browser functionality OS/Desktop labels Jul 26, 2023
@HEagle18 HEagle18 added this to Web3 Jul 26, 2023
@HEagle18 HEagle18 self-assigned this Aug 4, 2023
@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Aug 11, 2023
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Aug 11, 2023
@josheleonard josheleonard moved this from Backlog to In Review in Web3 Aug 15, 2023
@josheleonard josheleonard added the feature/web3/wallet Integrating Ethereum+ wallet support label Aug 15, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Aug 16, 2023
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Aug 16, 2023
@kjozwiak
Copy link
Member

The above requires 1.58.98 or higher for 1.58.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.58.100 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)
Revision a8c0058265009a1858c4502b9ba413671fbb61e1
OS Windows 11 Version 22H2 (Build 22621.2215)
31889.mp4

@srirambv
Copy link
Contributor

srirambv commented Sep 8, 2023

Verification passed on Oppo Reno 5 with Android 13 running 1.58.117 x64 build

31889.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants