Brave doesn't relaunch via taskbar Brave icon, after closing, if VPN is configured and Shields is enabled

[MadhaviSeelam]

Description

Brave doesn't open after closing via taskbar Brave icon if VPN is configured and Shields is enabled. Brave successfully relaunched once Shields is disabled on the VPN subscription page.

Steps to Reproduce

1. Install 1.57.47
2. launch Brave
3. click VPN button >> Already purchased VPN button
4. connect to VPN via VPN panel
5. close Brave
6. click Brave icon in the task bar to relaunch
7. it spins but Brave doesn't open/launch
8. open taskbar and end task for Brave browser background processes
9. click Brave icon in the taskbar and launch Brave
10. disable VPN in the VPN panel and close the browser
11. Brave doesn't relaunch
12. follow step 8 and terminate background processes from Brave browser
13. click Brave icon in the taskbar and launch Brave
14. turned Shield down for VPN subscription page
15. close the browser

Actual result:

If VPN is configured and Shields Up, Brave doesn't relaunch after closing. However, if Shields is down for VPN subscription page, Brave launch is successful via taskbar Brave icon after closing.

2023-08-16_11h13_44.mp4

Expected result:

Brave should relaunch successfully when Shields is enabled.

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.57.47 Chromium: 116.0.5845.96 (Official Build) (64-bit)
-- | --
Revision | 180d2fdf443f9be410c38fd8c4ccfe7e99ea2b16
OS | Windows 11 Version 22H2 (Build 22621.2134)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? No
• Can you reproduce this issue with the nightly channel? No

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@clifton @spylogsster

cc: @stephendonner

[stephendonner]

Sadly, can confirm this with

Brave | 1.57.47 Chromium: 116.0.5845.96 (Official Build) (64-bit)
-- | --
Revision | 180d2fdf443f9be410c38fd8c4ccfe7e99ea2b16
OS | Windows 10 Version 22H2 (Build 19045.3324)

cc @rebron @kjozwiak @LaurenWags as a heads-up

Nice find, @MadhaviSeelam

[stephendonner]

also cc @mattmcalister so he's aware

[spylogsster]

Looks like Nightly and Beta works fine, can someone else confirm? thanks
it also seems not related to Shields or account page, if ikev2 vpn connected the browser restarted after closing as background process.

[kjozwiak]

Closing the above as brave/brave-core#19735 was merged directly into 1.57.x as @MadhaviSeelam couldn't reproduce the issue on BETA nor Nightly.

[kjozwiak]

The above requires 1.57.52 or higher for 1.57.x verification 👍

[MadhaviSeelam]

Verification PASSED using

Brave | 1.57.52 Chromium: 116.0.5845.96 (Official Build) (64-bit)
-- | --
Revision | 1f876d1266f048189d3cc887cfa5208508ac8194
OS | Windows 11 Version 22H2 (Build 22621.2134)

Verified using original STR from #32309 (comment)

Confirmed as an existing user:

• after connecting to VPN via VPN panel and closing, successfully relaunched Brave via taskbar Brave icon
• after disconnecting VPN and closing, successfully relaunched Brave via taskbar Brave icon
• after connecting to VPN, disabling shields and closing, successfully relaunched Brave via taskbar Brave icon

example	example

[stephendonner]

Verification PASSED using

Brave | 1.57.52 Chromium: 116.0.5845.96 (Official Build) (64-bit)
-- | --
Revision | 1f876d1266f048189d3cc887cfa5208508ac8194
OS | Windows 10 Version 22H2 (Build 19045.3324)

Shared Steps:

1. installed 1.57.52
2. launched Brave
3. purchased, configured, and connected to Brave VPN via account.bravesoftware.com
4. left Brave open (additional tests will close/reopen)

Relaunch, connected - PASSED

(continued from Shared Steps)

1. remained connected
2. shut down Brave
3. relaunched via various methods (desktop shortcut, taskbar icon, Start/Programs menu, etc.)

example	example

Relaunch, disconnected - PASSED

(continued from Shared Steps)

1. disconnected from Brave VPN
2. shut down Brave
3. relaunched via various methods (desktop shortcut, taskbar icon, Start/Programs menu, etc.)

[stephendonner]

Verified PASSED using

Brave | 1.57.47 Chromium: 116.0.5845.96 (Official Build) (x86_64)
-- | --
Revision | 180d2fdf443f9be410c38fd8c4ccfe7e99ea2b16
OS | macOS Version 11.7.9 (Build 20G1426)

Regression-tested connecting, disconnecting, launching, and relaunching.

Confirmed all of the above worked whether disconnected or not

example	example	example	example	example	example