Unable to navigate Settings with keyboard

[Saoiray]

Description

If you try to navigate through and change settings using keyboard only, you're unable to move over to change anything. This means you can only change settings with a keyboard and mouse, which is an issue for some due to accessibility.

Steps to Reproduce

1. Open settings
2. Try using keyboard options like Tab, F6/F7, etc.
3. You'll find you can select categories like Get Started, System, etc.
4. However, if you try to navigate to sub options in those categories, you can't move to it or select.

Actual result:

So like in the screenshot below, I could open settings for Appearance but I can't navigate to change anything for Brave Colors, Theme, or anything else on the right side.

Expected result:

Should be able to fully navigate through the settings menus and make changes as necessary.

Reproduces how often:

Every attempt

Brave version (brave://version info)

Brave	1.58.127 Chromium: 117.0.5938.88 (Official Build) (64-bit)
Revision	ed4ee11d4f6add8e0885cfab17943837d3d426c1
OS	Windows 11 Version 22H2 (Build 22621.2283)

Version/Channel Information:

Release 1.58.127 and Nightly 1.60.41

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Didn't Test
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Is the issue reproducible on the latest version of Chrome? No, Chrome allows navigation as it should be.

Miscellaneous Information:

Reported by user at https://community.brave.com/t/changing-settings-while-using-accessibility-keys/506685

CC: @rebron

[anton-fck]

Hi, I would like to work on this issue.

[Saoiray]

@bsclifton @rebron @Brave-Matt can you guys help get eyes on this? Definitely is a Brave Browser only issue. Chromium, Vivaldi, Edge, and other Chromium based browsers allow for full navigation through Settings with keyboard only. For whatever reason, this isn't possible on any version/channel of Brave.

[anton-fck]

I eliminated the issue locally by manually adding role="menuitem" attribute to /help page hyperlink in the settings HTML page. The mentioned \help element is created here but without adding the role="menuitem" attribute.
However, I am unsure if the link should be considered a "menu item" since it's separated from other actual menu items. I also noticed that navigation to the search button is not possible as well.

[kjozwiak]

The above requires 1.65.126 or higher for 1.65.x verification(s) 👍

[LaurenWags]

Verified with

Brave | 1.65.126 Chromium: 124.0.6367.118 (Official Build) (x86_64)
-- | --
Revision | e6a0dcfed2e939addb42f91900875679412fa5b7
OS | macOS Version 13.6.6 (Build 22G630)

Reproduced the issue using 1.65.123 Chromium: 124.0.6367.91.
When using 1.65.126, confirmed able to navigate brave://settings using keyboard (tab, arrow keys, return, etc).

Screen.Recording.2024-05-01.at.8.39.30.AM.mov