Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for brave://settings - navigation and style #23348

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Apr 30, 2024

Fixes brave/brave-browser#33148
Fixes brave/brave-browser#37964

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used GitHub auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This matches the other navigation items and fixes keyboard navigation on settings

Kudos to @anton-fck for the suggestion!

Fixes brave/brave-browser#33148
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Apr 30, 2024
@bsclifton bsclifton changed the title Bsc fix settings navigation Fixes for brave://settings - navigation and style Apr 30, 2024
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@bsclifton bsclifton merged commit 8aa03e1 into master Apr 30, 2024
20 checks passed
@bsclifton bsclifton deleted the bsc-fix-settings-navigation branch April 30, 2024 22:02
@github-actions github-actions bot added this to the 1.67.x - Nightly milestone Apr 30, 2024
brave-builds added a commit that referenced this pull request May 1, 2024
brave-builds added a commit that referenced this pull request May 1, 2024
@kjozwiak
Copy link
Member

kjozwiak commented May 1, 2024

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.67.55 Chromium: 124.0.6367.91 (Official Build) nightly (64-bit)
-- | --
Revision | 7318e155bd47588e9f8094aadae2684a0ff34245
OS | Windows 11 Version 23H2 (Build 22631.3447)

Test Case #1 - brave/brave-browser#37964

1.67.53 Chromium: 124.0.6367.91 1.67.55 Chromium: 124.0.6367.91
reproducedSpacing image

Test Case #2 - brave/brave-browser#33148

Recording.2024-05-01.013416.mp4

kjozwiak pushed a commit that referenced this pull request May 1, 2024
kjozwiak pushed a commit that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings screen - autofill section is missing padding Unable to navigate Settings with keyboard
4 participants