Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for brave://settings - navigation and style (uplift to 1.66.x) #23360

Merged
merged 1 commit into from
May 1, 2024
Merged

Fixes for brave://settings - navigation and style (uplift to 1.66.x) #23360

merged 1 commit into from
May 1, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented May 1, 2024 •
edited by kjozwiak
Loading

Uplift of #23348
Fixes brave/brave-browser#33148
Fixes brave/brave-browser#37964

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner May 1, 2024 01:30
@brave-builds brave-builds added this to the 1.66.x - Beta milestone May 1, 2024
@brave-builds brave-builds self-assigned this May 1, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label May 1, 2024
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

kjozwiak
kjozwiak approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.66.x approved 👍 QA has verified the PR on Nighty using 1.67.x as per #23348 (comment).

@kjozwiak kjozwiak merged commit 8c15d27 into 1.66.x May 1, 2024
15 checks passed
@kjozwiak kjozwiak deleted the pr23348_bsc-fix-settings-navigation_1.66.x branch May 1, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.66.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @kjozwiak