Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening PDF in a tab shows chrome://extension URL and PDF extension favicon #368

Closed
srirambv opened this issue Jun 17, 2018 · 5 comments
Closed

Comments

@srirambv
Copy link
Contributor

Description

Opening PDF in a tab shows chrome://extension URL and PDF extension favicon

Steps to Reproduce

  1. Load any PDF in a new tab
  2. URL prefixes chrome-extension://oemmndcbldboiebfnladdacbdfmadadm/ to URL
  3. Tab shows PDF extension favicon instead of the site favicon

Actual result:

image

Expected result:

Should not show the extension prefix and should load the website favicon. Only show extension icon if site doesn't have favicon set

Reproduces how often:

Brave version (about:brave info)

Install build

@srirambv srirambv added this to the Releasable builds milestone Jun 17, 2018
@bbondy bbondy removed their assignment Jun 17, 2018
@bbondy bbondy modified the milestones: Releasable builds, Backlog Jun 17, 2018
@bbondy
Copy link
Member

bbondy commented Jun 17, 2018

I think this is actually OK for now, so moving to backlog. Valid though.

@diracdeltas diracdeltas added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 1, 2018
@shriram
Copy link

shriram commented Dec 1, 2018

Came here to report this; since there's already an open issue, I'll just add a comment to it. It looks like this is being worked on, so hopefully this will soon be moot, but I just want to respond to @bbondy's "it's OK" comment.

As an academic, I spend a lot of time reading PDF documents. It's not uncommon for me to go to a Web site (say a professor's publication list) and open up a bunch of documents in new tabs, and start reading. Eventually, I might get to one that's really interesting and I want to share with others. I can't just copy the URL and send it to someone else; either I have to manually edit it or they have to. Many people I know lack the facility to do this on either the sending or receiving side.

Since this is not the behavior in other browsers, there's no reason people would "just know" how to do such things. Especially since, to most users, the prefix (chrome-extension://oemmndcbldboiebfnladdacbdfmadadm/) looks like gibberish, and hence intimidating. Worse, in a context where the URL is presented through just a truncated prefix (e.g., a tweet), they wouldn't even see the suffix where the "real" URL resides.

In short, I think this is pretty user-unfriendly, and as Brave starts getting more non-expert users, this is bound to cause confusion and consternation.

Thanks for working on fixing this.

@cndouglas
Copy link
Contributor

This problem also hides the site info popup, which makes it harder to find the HTTPS certificate, cookies, and site settings.

Normal:

PDF:
image

@fmarier
Copy link
Member

fmarier commented Mar 22, 2019

I think we can close this in favor of #3846.

@fmarier fmarier removed their assignment Mar 22, 2019
@bbondy
Copy link
Member

bbondy commented Mar 22, 2019

yep

@bbondy bbondy closed this as completed Mar 22, 2019
@bbondy bbondy added closed/invalid and removed extension/PDFJS feature/extensions priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 22, 2019
@NejcZdovc NejcZdovc added this to the Dupe / Invalid / Not actionable milestone Jun 3, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants