Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Select Token Modal #37838

Closed
Douglashdaniel opened this issue Apr 24, 2024 · 1 comment · Fixed by brave/brave-core#23467
Closed

Update Select Token Modal #37838

Douglashdaniel opened this issue Apr 24, 2024 · 1 comment · Fixed by brave/brave-core#23467
Assignees
@Douglashdaniel
Labels
enhancement feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.68.x - Release

Comments

@Douglashdaniel
Copy link

Douglashdaniel commented Apr 24, 2024 •
edited
Loading

Description

We need to update the Select Token modal to latest designs and flows in Figma

  • Adds a Network filter
  • Adds an Account filter
  • Adds a Recently Traded Pairs section
  • Adds a Show zero balance tokens button
  • Will now be a flat list of tokens and moves away from grouping assets by Account
  • Introduces a Select Account modal after selecting a Token to swap

Screenshot 6
Screenshot 9
Screenshot 7
Screenshot 8
@Douglashdaniel Douglashdaniel added enhancement QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Apr 24, 2024
@Douglashdaniel Douglashdaniel self-assigned this Apr 24, 2024
This was referenced May 1, 2024
Open
Merged
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 10, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.68.84 Chromium: 126.0.6478.40 (Official Build) beta (64-bit)
Revision c5a3b2ff9dcc938c32b2c1b3a66847661db5d005
OS Windows 11 Version 23H2 (Build 22631.3672)
  • Verified steps from brave/brave-core#23467
  • Verified selecting a token shows account selection screen
  • Verified token list shows token listed under Owned and Not owned
  • Verified Not owned tokens shows an info button which when clicked loads the block explorer in a new tab
  • Verified when token balance is from multiple accounts, shows a user icon next to balance
37838.mp4

@LaurenWags LaurenWags mentioned this issue Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
enhancement feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.68.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Updated Select Token Modal brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds