Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build out Swap and Bridge Route Selection #38648

Closed
Douglashdaniel opened this issue May 28, 2024 · 3 comments · Fixed by brave/brave-core#24854
Closed

Build out Swap and Bridge Route Selection #38648

Douglashdaniel opened this issue May 28, 2024 · 3 comments · Fixed by brave/brave-core#24854
Assignees
@Douglashdaniel
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.70.x - Release

Comments

@Douglashdaniel
Copy link

Douglashdaniel commented May 28, 2024 •
edited
Loading

Platforms

Linux, macOS, Windows, Android

Description

We need to enable users to select available routes when initiating a Bridge or Swap transaction.

UI to be built out can be found in our Figma designs here

https://www.figma.com/design/26xCR66ZscSyVpTKrt85Hn/Transactions?node-id=601-134140&t=ZhJJwbyG9qKXTRAv-0

Screenshot 9
@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature-request feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes labels May 28, 2024
@Douglashdaniel Douglashdaniel self-assigned this May 28, 2024
@Douglashdaniel Douglashdaniel mentioned this issue May 28, 2024
Merged
24 tasks
@Douglashdaniel Douglashdaniel mentioned this issue Jul 25, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.70.x - Nightly milestone Jul 29, 2024
@LaurenWags
Copy link
Member

@Douglashdaniel please add the appropriate platform label(s):

  • OS/Desktop and/or OS/Android and/or OS/iOS

@srirambv
Copy link
Contributor

srirambv commented Sep 9, 2024

Verification passed on

Brave 1.70.101 Chromium: 128.0.6613.120 (Official Build) beta (64-bit)
Revision dc28ab38d07e9fa668801884c0c55f669ce538eb
OS Windows 11 Version 23H2 (Build 22631.4037)
  • Verified steps from brave/brave-core#24854
  • Verified Swap and Bridge has route selection
  • Verified updating the provider automatically updates the quotes accordingly
38648.mp4

@Douglashdaniel Douglashdaniel added the OS/Android Fixes related to Android browser functionality label Sep 11, 2024
@srirambv
Copy link
Contributor

Verification passed on Google Pixel 8 with Android 14 running 1.70.107 x64 Beta build

  • Verified steps from brave/brave-core#24854
  • Verified Swap and Bridge has route selection
  • Verified updating the provider automatically updates the quotes accordingly
38648.mp4

@hffvld hffvld mentioned this issue Sep 16, 2024
Closed
@LaurenWags LaurenWags mentioned this issue Sep 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support feature-request front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.70.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Swap and Bridge Route Selection Modal brave/brave-core
5 participants
@kjozwiak @srirambv @LaurenWags @Douglashdaniel @brave-builds