Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AI Rewriter]: It should be possible to rewrite the page text with the AI Rewriter Dialog #38660

Closed
fallaciousreasoning opened this issue May 29, 2024 · 6 comments · Fixed by brave/brave-core#23780
Closed

[AI Rewriter]: It should be possible to rewrite the page text with the AI Rewriter Dialog #38660

fallaciousreasoning opened this issue May 29, 2024 · 6 comments · Fixed by brave/brave-core#23780
Assignees
@fallaciousreasoning
Labels
browser-ai OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No QA/Test-Plan-Required release-notes/exclude
Milestone
1.68.x - Release

Comments

@fallaciousreasoning
Copy link

  1. It should be possible to insert generated text
  2. Followup prompts should be possible
  3. You should be able to go back/forward through suggestions
  4. You should be able to reset the rewriter state to the original text
@fallaciousreasoning fallaciousreasoning mentioned this issue May 29, 2024
Merged
24 tasks
@mattmcalister mattmcalister added QA/Yes release-notes/include browser-ai priority/P2 A bad problem. We might uplift this to the next planned release. labels May 30, 2024
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone Jun 4, 2024
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 12, 2024
@stephendonner
Copy link

stephendonner commented Jun 12, 2024 •
edited
Loading

Verification IN-PROGRESS using

Brave | 1.68.86 Chromium: 126.0.6478.56 (Official Build) beta (64-bit)
-- | --
Revision | b4eadb4942277a3eb455fc7c3c8569185bd745af
OS | Windows 10 Version 22H2 (Build 19045.4474)

image

@stephendonner
Copy link

@fallaciousreasoning I've started on this, but don't have a good idea of where to go/what to do, after enabling the feature flag.

Mind please adding a testplan to the issue/PR? Thanks!

@fallaciousreasoning
Copy link
Author

Let's hold off on this @stephendonner - it's pretty early and the changes to the conversation_api have broken it 😄 Sorry about that!

@stephendonner stephendonner added QA/Blocked and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 12, 2024
@stephendonner
Copy link

stephendonner commented Jun 12, 2024 •
edited
Loading

Setting to QA/Blocked as this both needs more work to be ready for QA, as well as an accompanying testplan. cc @brave/qa-team

@LaurenWags
Copy link
Member

Removed QA/Blocked as this was changed to QA/No per discussion via https://bravesoftware.slack.com/archives/C05NDQP03AQ/p1719340292321519?thread_ts=1718227470.817659&cid=C05NDQP03AQ.

@LaurenWags LaurenWags mentioned this issue Jul 22, 2024
Closed
@LaurenWags
Copy link
Member

Changing to release-notes/exclude per the above and after conferring with @kjozwiak @rebron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
browser-ai OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No QA/Test-Plan-Required release-notes/exclude
Projects
Browser AI
Status: Done
Milestone
1.68.x - Release
Development

Successfully merging a pull request may close this issue.

[AI Rewriter]: Implement ability to rewrite text brave/brave-core
5 participants
@mattmcalister @stephendonner @fallaciousreasoning @LaurenWags @brave-builds