Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Incorrect deposit address shown in deposit-funds screen #38833

Closed
3 of 6 tasks
josheleonard opened this issue Jun 5, 2024 · 2 comments · Fixed by brave/brave-core#24015
Closed
3 of 6 tasks
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include

Comments

@josheleonard
Copy link

Description

Attempting to deposit displays the Account 1 address no matter which account is selected. https://community.brave.com/t/deposit-address-not-changing-for-multiple-accounts/549656

Steps to reproduce

  1. create a wallet with multiple ETH accounts.
  2. select Deposit
  3. select the ETH network token
  4. continue to next screen

Actual result

It shows an address and a QR code for one of my accounts.
When switching to a different account using the selector above the QR code, the QR code and the address don’t change. They still show the other account’s QR and address

Expected result

When switching to a different account using the selector above the QR code, the QR code and the address should change to the correct address

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.66.118 Chromium: 125.0.6422.147 (Official Build) (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

https://community.brave.com/t/deposit-address-not-changing-for-multiple-accounts/549656

@LaurenWags
Copy link
Member

Requires 1.67.110 or higher for testing 👍🏻

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.67.110 Chromium: 126.0.6478.40 (Official Build) (64-bit)
Revision ac00bac697a2d9dad0b2e7f832391263816fd78d
OS Windows 11 Version 23H2 (Build 22631.3672)
  • Verified steps from issue description
  • Verified address and QR code changes when selected on Deposit screen
38833.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants