Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom filter lists added to standard engine #40034

Closed
1 of 5 tasks
cuba opened this issue Jul 26, 2024 · 0 comments · Fixed by brave/brave-core#24869
Closed
1 of 5 tasks

Custom filter lists added to standard engine #40034

cuba opened this issue Jul 26, 2024 · 0 comments · Fixed by brave/brave-core#24869
Assignees
Labels
OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude

Comments

@cuba
Copy link

cuba commented Jul 26, 2024

Description

We have 2 engines: standard and aggressive (also known as default and additional). In the standard engine only the default filter lists and iOS only filter list should go inside (controlled by the list catalog). All other filter lists should go to the aggressive engine. Including custom filter lists.

However custom filter lists are going to both engines: standard and aggressive.

Steps to reproduce

This is not reproducible as there is no side-effect except by using more phone resources. You may however see somewhat faster launch speeds with the fix.

Actual result

N/A

Expected result

Reproduces how often

No reproduction steps

Brave version

1.70.x

Device/iOS version

Any (older the more prominant)

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants