Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appropriate error message should be shown when not cached media file is played when no internet/wifi connection available #40325

Open
1 of 6 tasks
MadhaviSeelam opened this issue Aug 6, 2024 · 2 comments
Assignees
Labels
bug design A design change, especially one which needs input from the design team features/playlist OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Aug 6, 2024

Description

Description
Found while testing #32585. If a media file is not cached (i.e. Automatically add files for offline viewingsetting is disabled) and internet/wifi is disconnected and media played in the playlist panel, it will play for about 3 minutes after disconnecting wifi. The frame is frozen and later if switched to different media file,Failed to play itemerror along withmay be expirederror is shown. YouTube page is shown withConnect to the internetandNo internet connection` message at the bottom. Not sure if this is expected.

Steps to reproduce

  1. Install 1.70.44
  2. launch/relaunch Brave
  3. open brave://settings/braveContent
  4. disable Automatically add files for offline viewing setting
  5. Add few videos to the Playlist
  6. disconnect internet/wifi connection

Actual result

media played for about 3 minutes
frame is frozen but nothing happens
switching to another file causes an error message to load

2024-08-05_18h42_16.mp4

Expected result

Appropriate error message?

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.70.44 Chromium: 127.0.6533.88 (Official Build) nightly (64-bit)
Revision c6e95da37b2d012afdca7bcc03a727e24cb2bb1c
OS Windows 11 Version 23H2 (Build 22631.3958)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

@rebron @bsclifton @sangwoo108
cc: @brave/qa-team

@rebron rebron changed the title Appropriate error message should be shown when not cached media file is played when no internet/wife connection available Appropriate error message should be shown when not cached media file is played when no internet/wifi connection available Aug 7, 2024
@rebron rebron assigned rebron and aguscruiz and unassigned rebron Aug 7, 2024
@rebron rebron added design A design change, especially one which needs input from the design team priority/P3 The next thing for us to work on. It'll ride the trains. labels Aug 7, 2024
@aguscruiz
Copy link

What about something like this
https://www.figma.com/design/RxyQnpxi9qtf5HmnAj1yH0/Desktop-Playlist?node-id=3593-23469&t=tGRUeYKbcwW1zKfL-1

What do you think about the copy @rebron

image

@rebron
Copy link
Collaborator

rebron commented Aug 7, 2024

The copy looks good. I don't think we need to encourage caching the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design A design change, especially one which needs input from the design team features/playlist OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

3 participants