A/C goes through despite being turned OFF

[mandar-brave]

Auto contributions are going through in all current releases (0.71, 0.70, 0.69) and the latest nightly even if the user has turned off the A/C switch.

cc @NejcZdovc

[eljuno]

+1s from Community

https://community.brave.com/t/random-auto-contribute-even-though-it-was-off/90845?u=eljuno

[SaltwaterC]

You sent 5 BAT to @BravePublishers

This has been automatically executed on a Windows installation of Brave.

TX id: 5d8ef5ca-d073-4fd5-9dc1-a3966c1b3882

[LaurenWags]

Verified passed with

Brave	0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	macOS Version 10.13.6 (Build 17G5019)

• Verified test plan from Fixes ac being processed when ac is off brave-core#3915
• Confirmed if AC table contains verified publishers and AC is toggled OFF, AC does not go thru.
• Confirmed if AC table contains verified publishers and AC is toggled OFF and recurring monthly tips are set up, AC does not go thru but recurring monthly tips are contributed as expected.
• Confirmed if AC table contains verified publishers and Rewards is toggled OFF (but AC is not explicitly toggled off), AC does not go thru.
• Confirmed if AC table contains verified publishers and recurring monthly tips are set up and Rewards is toggled OFF (but AC is not explicitly toggled off), AC does not go thru AND recurring monthly tips are not contributed. Works as expected.
• Confirmed if Rewards are ON, AC is ON (and contains verified publishers) and recurring monthly tips are set up, AC and recurring monthly tips are contributed as expected.

Verification passed on

Brave	0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified test plan from Fixes ac being processed when ac is off brave-core#3915
• Confirmed if AC table contains verified publishers and AC is toggled OFF, AC does not go thru.
• Confirmed if AC table contains verified publishers and AC is toggled OFF and recurring monthly tips are set up, AC does not go thru but recurring monthly tips are contributed as expected.
  
• Confirmed if AC table contains verified publishers and Rewards is toggled OFF (but AC is not explicitly toggled off), AC does not go thru.
• Confirmed if AC table contains verified publishers and recurring monthly tips are set up and Rewards is toggled OFF (but AC is not explicitly toggled off), AC does not go thru AND recurring monthly tips are not contributed. Works as expected.
• Confirmed if Rewards are ON, AC is ON (and contains verified publishers) and recurring monthly tips are set up, AC and recurring monthly tips are contributed as expected.
  

Verification passed on

Brave	0.71.115 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision	021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS	Ubuntu 18.04 LTS

• Verified test plan from Fixes ac being processed when ac is off brave-core#3915
• Confirmed if AC table contains verified publishers and AC is toggled OFF, AC does not go thru.
• Confirmed if AC table contains verified publishers and AC is toggled OFF and recurring monthly tips are set up, AC does not go thru but recurring monthly tips are contributed as expected.
  
• Confirmed if AC table contains verified publishers and Rewards is toggled OFF (but AC is not explicitly toggled off), AC does not go thru.
• Confirmed if AC table contains verified publishers and recurring monthly tips are set up and Rewards is toggled OFF (but AC is not explicitly toggled off), AC does not go thru AND recurring monthly tips are not contributed. Works as expected.
• Confirmed if Rewards are ON, AC is ON (and contains verified publishers) and recurring monthly tips are set up, AC and recurring monthly tips are contributed as expected.