Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A/C goes through despite being turned OFF #6716

Closed
mandar-brave opened this issue Nov 1, 2019 · 3 comments · Fixed by brave/brave-core#3915

Comments

@mandar-brave
Copy link
Collaborator

@mandar-brave mandar-brave commented Nov 1, 2019

Auto contributions are going through in all current releases (0.71, 0.70, 0.69) and the latest nightly even if the user has turned off the A/C switch.

cc @NejcZdovc

@mandar-brave mandar-brave added this to New Issues in Rewards via automation Nov 1, 2019
@NejcZdovc NejcZdovc self-assigned this Nov 1, 2019
@eljuno

This comment has been minimized.

@SaltwaterC

This comment has been minimized.

Copy link

@SaltwaterC SaltwaterC commented Nov 6, 2019

You sent 5 BAT to @BravePublishers

This has been automatically executed on a Windows installation of Brave.

TX id: 5d8ef5ca-d073-4fd5-9dc1-a3966c1b3882

NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 7, 2019
@NejcZdovc NejcZdovc mentioned this issue Nov 7, 2019
7 of 32 tasks complete
@NejcZdovc NejcZdovc added the QA/Yes label Nov 7, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 7, 2019
Rewards automation moved this from New Issues to Done Nov 8, 2019
@NejcZdovc NejcZdovc added this to the 0.74.x - Nightly milestone Nov 8, 2019
@LaurenWags

This comment has been minimized.

Copy link
Collaborator

@LaurenWags LaurenWags commented Nov 11, 2019

Verified passed with

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified test plan from brave/brave-core#3915
  • Confirmed if AC table contains verified publishers and AC is toggled OFF, AC does not go thru.
  • Confirmed if AC table contains verified publishers and AC is toggled OFF and recurring monthly tips are set up, AC does not go thru but recurring monthly tips are contributed as expected.
  • Confirmed if AC table contains verified publishers and Rewards is toggled OFF (but AC is not explicitly toggled off), AC does not go thru.
  • Confirmed if AC table contains verified publishers and recurring monthly tips are set up and Rewards is toggled OFF (but AC is not explicitly toggled off), AC does not go thru AND recurring monthly tips are not contributed. Works as expected.
  • Confirmed if Rewards are ON, AC is ON (and contains verified publishers) and recurring monthly tips are set up, AC and recurring monthly tips are contributed as expected.

Verification passed on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from brave/brave-core#3915
  • Confirmed if AC table contains verified publishers and AC is toggled OFF, AC does not go thru.
  • Confirmed if AC table contains verified publishers and AC is toggled OFF and recurring monthly tips are set up, AC does not go thru but recurring monthly tips are contributed as expected.
    image
  • Confirmed if AC table contains verified publishers and Rewards is toggled OFF (but AC is not explicitly toggled off), AC does not go thru.
  • Confirmed if AC table contains verified publishers and recurring monthly tips are set up and Rewards is toggled OFF (but AC is not explicitly toggled off), AC does not go thru AND recurring monthly tips are not contributed. Works as expected.
  • Confirmed if Rewards are ON, AC is ON (and contains verified publishers) and recurring monthly tips are set up, AC and recurring monthly tips are contributed as expected.
    image

Verification passed on

Brave 0.71.115 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS
  • Verified test plan from brave/brave-core#3915
  • Confirmed if AC table contains verified publishers and AC is toggled OFF, AC does not go thru.
  • Confirmed if AC table contains verified publishers and AC is toggled OFF and recurring monthly tips are set up, AC does not go thru but recurring monthly tips are contributed as expected.
    image
  • Confirmed if AC table contains verified publishers and Rewards is toggled OFF (but AC is not explicitly toggled off), AC does not go thru.
  • Confirmed if AC table contains verified publishers and recurring monthly tips are set up and Rewards is toggled OFF (but AC is not explicitly toggled off), AC does not go thru AND recurring monthly tips are not contributed. Works as expected.
  • Confirmed if Rewards are ON, AC is ON (and contains verified publishers) and recurring monthly tips are set up, AC and recurring monthly tips are contributed as expected.
    image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.