Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSplit patches #37
Split patches #37
Conversation
| // When splitting one large diff into a per-file diff, there are a few ways | ||
| // you can go about it. Because different files can have the same name | ||
| // (by being located in different directories), you need to avoid collisions. | ||
| // Mirroring the directory structure seems undesirable. |
This comment has been minimized.
This comment has been minimized.
bridiver
Dec 19, 2017
Collaborator
I'm not sure that it is undesirable. I think we should either mimic the actual directory structure or make the directory part of the file name (net/base/network_delegate.cc -> net-base-network_delegate.cc)
This comment has been minimized.
This comment has been minimized.
bridiver
Dec 19, 2017
Collaborator
the reason is that if I'm searching for a particular patch file, I want an easy way to identify it without looking at the actual contents
This comment has been minimized.
This comment has been minimized.
kevinlawler
Dec 19, 2017
Author
Contributor
The way it currently works is net/base/network_delegate.cc -> net.base.network_delegate.cc
This comment has been minimized.
This comment has been minimized.
kevinlawler
Dec 19, 2017
Author
Contributor
(We can make it do dashes by changing desiredReplacementString)
This comment has been minimized.
This comment has been minimized.
| } | ||
|
|
||
| if (replacingBackslashes) { | ||
| revised = revised.replace(/\\/g, desiredReplacementString) |
This comment has been minimized.
This comment has been minimized.
|
this looks good, but we should probably do an antimuon PR as well to actually split them |
outside issue: brave/brave#36 outside pr: brave/brave#37
kevinlawler
force-pushed the
split-patches
branch
2 times, most recently
from
0a1811c
to
29eae05
|
++ |
| console.log('updatePatches wrote ' + (1 + i) + '/' + n + ': ' + filename) | ||
| } | ||
|
|
||
| // finish off by creating one big patch for deleted files |
This comment has been minimized.
This comment has been minimized.
bridiver
Dec 29, 2017
Collaborator
I think we can probably leave this out. I can't think of any reason why we would need to delete a file vs patching a build script to leave it out
outside issue: brave/brave#36 outside pr: brave/brave#37 standardize to a/ b/ diff prefixes
and one big file for Deleted files for issue brave/brave#36 fixes from pr comments: use '-' as separator only need to replace '/' not '\\' standardize diff prefixes to a/ and b/
outside issue: brave/brave#36 outside pr: brave/brave#37 standardize to a/ b/ diff prefixes remove master_deleted_patch
Build and use dump_syms on Windows and Mac
kevinlawler commentedDec 16, 2017
•
edited
brave/brave#36