Support unified adblock catalog #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonok-edm
force-pushed
the
unified-catalog
branch
from
98f9eb5
to
4ab7272
Compare
antonok-edm
force-pushed
the
unified-catalog
branch
from
4ab7272
to
93fad7e
Compare
This was referenced Aug 30, 2023
fmarier
approved these changes
Aug 31, 2023
antonok-edm
force-pushed
the
unified-catalog
branch
from
93fad7e
to
b66a80a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for brave/brave-core#19946
Depends on brave/adblock-resources#130
Will update
listCatalogUrlprior to merging - right now it points to theunified-catalogbranch ofadblock-resources.list_catalog.jsonis added directly into the existing regional catalog component.regional_catalog.jsonis still generated from the contents oflist_catalog.jsonand added there for backwards compatibility. It can be removed once most users have updated beyond the versions wherelist_catalog.jsonis supported.