Add dapp detection

contents script in brave extension detects whether window.web3 is accessed or not
from current tab and sends a message to background script to notify to browser.
When browser gets "braveShields.dappAvailable", it shows wallet extension install
guide when dapp detection pref is enabled.

app/brave_generated_resources.grd

@@ -163,6 +163,9 @@
       <message name="IDS_WIDEVINE_PERMISSION_REQUEST_TEXT_FRAGMENT" desc="Text fragment for Widevine permission request. 'Widevine' is the name of a plugin and should not be translated.">
           Install and run Widevine
       </message>
+      <message name="IDS_WALLET_PERMISSION_REQUEST_TEXT_FRAGMENT" desc="Text fragment for wallet installation permission request.">
+          Install cryptocurrency wallet
+      </message>
       <if expr="is_linux">
         <message name="IDS_WIDEVINE_PERMISSION_REQUEST_TEXT_FRAGMENT_INSTALL" desc="Text fragment for Widevine permission request. 'Widevine' is the name of a plugin and should not be translated.">
           Install Widevine

browser/BUILD.gn

@@ -137,6 +137,10 @@ source_set("browser_process") {
       "brave_rewards/rewards_tab_helper.h",
       "brave_rewards/tip_dialog.cc",
       "brave_rewards/tip_dialog.h",
+      "dapp/dapp_utils.cc",
+      "dapp/dapp_utils.h",
+      "dapp/wallet_installation_permission_request.cc",
+      "dapp/wallet_installation_permission_request.h",
     ]
 
     deps += [

browser/brave_profile_prefs.cc

@@ -120,6 +120,9 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
 
   // IPFS companion extension
   registry->RegisterBooleanPref(kIPFSCompanionEnabled, false);
+
+  // Dapp detection
+  registry->RegisterBooleanPref(kDappDetectionEnabled, false);
 }
 
 }  // namespace brave

browser/dapp/dapp_utils.cc

@@ -0,0 +1,36 @@
+/* Copyright (c) 2019 The Brave Authors. All rights reserved.
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+#include "brave/browser/dapp/dapp_utils.h"
+
+#include "base/callback.h"
+#include "brave/browser/dapp/wallet_installation_permission_request.h"
+#include "brave/common/pref_names.h"
+#include "chrome/browser/permissions/permission_request_manager.h"
+#include "chrome/browser/profiles/profile.h"
+#include "components/prefs/pref_service.h"
+
+namespace {
+base::Closure g_quit_closure_for_test;
+}  // namespace
+
+bool DappDetectionEnabled(content::BrowserContext* browser_context) {
+  Profile* profile = Profile::FromBrowserContext(browser_context);
+  return profile->GetPrefs()->GetBoolean(kDappDetectionEnabled);
+}
+
+void RequestWalletInstallationPermission(content::WebContents* web_contents) {
+  DCHECK(web_contents);
+
+  if (g_quit_closure_for_test)
+    g_quit_closure_for_test.Run();
+
+  PermissionRequestManager::FromWebContents(web_contents)->AddRequest(
+      new WalletInstallationPermissionRequest(web_contents));
+}
+
+void SetQuitClosureForDappDetectionTest(const base::Closure& quit_closure) {
+  g_quit_closure_for_test = quit_closure;
+}

browser/dapp/dapp_utils.h

@@ -0,0 +1,21 @@
+/* Copyright (c) 2019 The Brave Authors. All rights reserved.
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+#ifndef BRAVE_BROWSER_DAPP_DAPP_UTILS_H_
+#define BRAVE_BROWSER_DAPP_DAPP_UTILS_H_
+
+#include "base/callback_forward.h"
+
+namespace content {
+class BrowserContext;
+class WebContents;
+}  // content
+
+bool DappDetectionEnabled(content::BrowserContext* browser_context);
+void RequestWalletInstallationPermission(content::WebContents* web_contents);
+
+void SetQuitClosureForDappDetectionTest(const base::Closure& quit_closure);
+
+#endif  // BRAVE_BROWSER_DAPP_DAPP_UTILS_H_

browser/dapp/wallet_installation_permission_request.cc

@@ -0,0 +1,57 @@
+/* Copyright (c) 2019 The Brave Authors. All rights reserved.
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+#include "brave/browser/dapp/wallet_installation_permission_request.h"
+
+#include "brave/grit/brave_generated_resources.h"
+#include "chrome/app/vector_icons/vector_icons.h"
+#include "content/public/browser/web_contents.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "url/gurl.h"
+
+WalletInstallationPermissionRequest::WalletInstallationPermissionRequest(
+    content::WebContents* web_contents)
+    : web_contents_(web_contents) {
+}
+
+WalletInstallationPermissionRequest::~WalletInstallationPermissionRequest() {
+}
+
+PermissionRequest::IconId
+WalletInstallationPermissionRequest::GetIconId() const {
+  return kExtensionIcon;
+}
+
+base::string16
+WalletInstallationPermissionRequest::GetMessageTextFragment() const {
+  return l10n_util::GetStringUTF16(
+      IDS_WALLET_PERMISSION_REQUEST_TEXT_FRAGMENT);
+}
+
+GURL WalletInstallationPermissionRequest::GetOrigin() const {
+  return web_contents_->GetVisibleURL();
+}
+
+void WalletInstallationPermissionRequest::PermissionGranted() {
+  // TODO(shong): Install wallet.
+  NOTIMPLEMENTED();
+}
+
+void WalletInstallationPermissionRequest::PermissionDenied() {
+  // Do nothing.
+}
+
+void WalletInstallationPermissionRequest::Cancelled() {
+  // Do nothing.
+}
+
+void WalletInstallationPermissionRequest::RequestFinished() {
+  delete this;
+}
+
+PermissionRequestType
+WalletInstallationPermissionRequest::GetPermissionRequestType() const {
+  return PermissionRequestType::PERMISSION_WALLET;
+}

browser/dapp/wallet_installation_permission_request.h

@@ -0,0 +1,41 @@
+/* Copyright (c) 2019 The Brave Authors. All rights reserved.
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+#ifndef BRAVE_BROWSER_DAPP_WALLET_INSTALLATION_PERMISSION_REQUEST_H_
+#define BRAVE_BROWSER_DAPP_WALLET_INSTALLATION_PERMISSION_REQUEST_H_
+
+#include "chrome/browser/permissions/permission_request.h"
+
+namespace content {
+class WebContents;
+}
+
+class GURL;
+
+class WalletInstallationPermissionRequest : public PermissionRequest {
+ public:
+  explicit WalletInstallationPermissionRequest(
+      content::WebContents* web_contents);
+  ~WalletInstallationPermissionRequest() override;
+
+ private:
+  // PermissionRequest overrides:
+  PermissionRequest::IconId GetIconId() const override;
+  base::string16 GetMessageTextFragment() const override;
+  GURL GetOrigin() const override;
+  void PermissionGranted() override;
+  void PermissionDenied() override;
+  void Cancelled() override;
+  void RequestFinished() override;
+  PermissionRequestType GetPermissionRequestType() const override;
+
+  // It's safe to use this raw |web_contents_| because this request is deleted
+  // by PermissionManager that is tied with this |web_contents_|.
+  content::WebContents* web_contents_;
+
+  DISALLOW_COPY_AND_ASSIGN(WalletInstallationPermissionRequest);
+};
+
+#endif  // BRAVE_BROWSER_DAPP_WALLET_INSTALLATION_PERMISSION_REQUEST_H_

browser/extensions/api/brave_shields_api.cc

@@ -10,6 +10,7 @@
 #include <utility>
 
 #include "base/strings/string_number_conversions.h"
+#include "brave/browser/dapp/dapp_utils.h"
 #include "brave/common/extensions/api/brave_shields.h"
 #include "brave/common/extensions/extension_constants.h"
 #include "brave/components/brave_shields/browser/brave_shields_web_contents_observer.h"
@@ -82,6 +83,34 @@ ExtensionFunction::ResponseAction BraveShieldsAllowScriptsOnceFunction::Run() {
   return RespondNow(NoArguments());
 }
 
+ExtensionFunction::ResponseAction
+BraveShieldsDappAvailableFunction::Run() {
+  std::unique_ptr<brave_shields::DappAvailable::Params> params(
+      brave_shields::DappAvailable::Params::Create(*args_));
+  EXTENSION_FUNCTION_VALIDATE(params.get());
+
+  if (!DappDetectionEnabled(browser_context()))
+    return RespondNow(NoArguments());
+
+  // Get web contents for this tab
+  content::WebContents* contents = nullptr;
+  if (!ExtensionTabUtil::GetTabById(
+        params->tab_id,
+        Profile::FromBrowserContext(browser_context()),
+        include_incognito_information(),
+        nullptr,
+        nullptr,
+        &contents,
+        nullptr)) {
+    return RespondNow(Error(tabs_constants::kTabNotFoundError,
+                            base::NumberToString(params->tab_id)));
+  }
+
+  RequestWalletInstallationPermission(contents);
+
+  return RespondNow(NoArguments());
+}
+
 ExtensionFunction::ResponseAction
 BraveShieldsContentSettingGetFunction::Run() {
   ContentSettingsType content_type;

browser/extensions/api/brave_shields_api.h

@@ -1,4 +1,5 @@
-/* This Source Code Form is subject to the terms of the Mozilla Public
+/* Copyright (c) 2019 The Brave Authors. All rights reserved.
+ * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this file,
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
@@ -20,6 +21,16 @@ class BraveShieldsAllowScriptsOnceFunction : public UIThreadExtensionFunction {
   ResponseAction Run() override;
 };
 
+class BraveShieldsDappAvailableFunction : public UIThreadExtensionFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION("braveShields.dappAvailable", UNKNOWN)
+
+ protected:
+  ~BraveShieldsDappAvailableFunction() override {}
+
+  ResponseAction Run() override;
+};
+
 class BraveShieldsContentSettingGetFunction
     : public UIThreadExtensionFunction {
  public:

browser/extensions/api/brave_shields_api_browsertest.cc

@@ -3,6 +3,7 @@
  * You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "base/path_service.h"
+#include "brave/browser/dapp/dapp_utils.h"
 #include "brave/browser/extensions/api/brave_shields_api.h"
 #include "brave/common/brave_paths.h"
 #include "brave/common/extensions/extension_constants.h"
@@ -17,12 +18,14 @@
 #include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
+#include "brave/common/pref_names.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/test/browser_test_utils.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "components/content_settings/core/common/content_settings.h"
 #include "components/content_settings/core/common/content_settings_types.h"
+#include "components/prefs/pref_service.h"
 #include "extensions/common/extension_builder.h"
 #include "net/dns/mock_host_resolver.h"
 
@@ -321,4 +324,14 @@ IN_PROC_BROWSER_TEST_F(BraveShieldsAPIBrowserTest,
   EXPECT_EQ(setting, CONTENT_SETTING_BLOCK);
 }
 
+IN_PROC_BROWSER_TEST_F(BraveShieldsAPIBrowserTest, DappDetectionTest) {
+  browser()->profile()->GetPrefs()->SetBoolean(kDappDetectionEnabled, true);
+  EXPECT_TRUE(
+      NavigateToURLUntilLoadStop("a.com", "/dapp.html"));
+
+  base::RunLoop loop;
+  SetQuitClosureForDappDetectionTest(loop.QuitClosure());
+  loop.Run();
+}
+
 }  // namespace extensions

chromium_src/chrome/browser/permissions/permission_uma_util.cc

@@ -19,6 +19,8 @@ std::string GetPermissionRequestString(PermissionRequestType type) {
     return "Autoplay";
   if (type == PermissionRequestType::PERMISSION_WIDEVINE)
     return "Widevine";
+  if (type == PermissionRequestType::PERMISSION_WALLET)
+    return "Wallet";
   return GetPermissionRequestString_ChromiumImpl(type);
 }
 

common/extensions/api/brave_shields.json

@@ -49,6 +49,24 @@
             "parameters": []
           }
         ]
+      },
+      {
+        "name": "dappAvailable",
+        "type": "function",
+        "description": "Called when website is dapp",
+        "parameters": [
+          {
+            "name": "tabID",
+            "type": "integer"
+          },
+          {
+            "type": "function",
+            "name": "callback",
+            "optional": true,
+            "parameters": [
+            ]
+          }
+        ]
       }
     ],
     "types": [

common/pref_names.cc

@@ -52,3 +52,4 @@ const char kWebTorrentEnabled[] = "brave.webtorrent_enabled";
 const char kHangoutsEnabled[] = "brave.hangouts_enabled";
 const char kHideBraveRewardsButton[] = "brave.hide_brave_rewards_button";
 const char kIPFSCompanionEnabled[] = "brave.ipfs_companion_enabled";
+const char kDappDetectionEnabled[] = "brave.dapp_detection_enabled";

common/pref_names.h

@@ -46,5 +46,6 @@ extern const char kWebTorrentEnabled[];
 extern const char kHangoutsEnabled[];
 extern const char kHideBraveRewardsButton[];
 extern const char kIPFSCompanionEnabled[];
+extern const char kDappDetectionEnabled[];
 
 #endif  // BRAVE_COMMON_PREF_NAMES_H_

components/brave_extension/extension/brave_extension/background/events.ts

@@ -8,3 +8,4 @@ require('./events/shieldsEvents')
 require('./events/runtimeEvents')
 require('./events/webNavigationEvents')
 require('./events/cosmeticFilterEvents')
+require('./events/dappDetectionEvents')

components/brave_extension/extension/brave_extension/background/events/dappDetectionEvents.ts

@@ -0,0 +1,19 @@
+/* Copyright (c) 2019 The Brave Authors. All rights reserved.
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this file,
+ * You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+// content script listener for dapp detection.
+chrome.runtime.onMessage.addListener((msg, sender, sendResponse) => {
+  switch (msg.type) {
+    case 'dappAvailable': {
+      chrome.tabs.query({ active: true, currentWindow: true }, function (tabs: chrome.tabs.Tab[]) {
+        // Only notify when this message is comes from active tab.
+        if (msg.location === tabs[0].url) {
+          chrome.braveShields.dappAvailable(tabs[0].id)
+        }
+      })
+      break
+    }
+  }
+})