-
Notifications
You must be signed in to change notification settings - Fork 877
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
PasswordStoreInterface
removal methods ask location
This change corrects both calling sites as well as overriding methods that must now provide a location argument. No attempt has been done in making any use of the location data in cases where the argument is necessary to override the function. Chromium change: https://chromium.googlesource.com/chromium/src/+/cdacee55c70cc463b7079cec258de4a6d7188506 commit cdacee55c70cc463b7079cec258de4a6d7188506 Author: Mikel Astiz <mastiz@chromium.org> Date: Wed Apr 24 18:42:38 2024 +0000 [passwords] Require base::Location for PasswordStoreInterface removals This patch extends PasswordStoreInterface and all implementations with a new argument in APIs that issue password deletions. Callers must specify a base::Location, often FROM_HERE, that allows tracing where a deletion request originated. The goal is to consume this information for logging purposes, in case user reports need to be investigated. The plumbing required for Sync code to consume this information will be tackled in follow-up patches. Change-Id: I0c6bbc250ea67f10e3d5e3879f674003a86f3abc
- Loading branch information
1 parent
8b3cb31
commit b2f7607
Showing
4 changed files
with
13 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters