Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Google Hangouts / Google Meet #1227

Merged
merged 4 commits into from
Jan 8, 2019
Merged

Add support for Google Hangouts / Google Meet #1227

merged 4 commits into from
Jan 8, 2019

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jan 5, 2019

This fixes screen share feature and probably other things for Google Hangouts and Google Meet.

Fix brave/brave-browser#1982
Requires: brave/brave-browser#1983

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Without it screens hare doesn't work unless you turn it on, off, then on again.
@bbondy bbondy changed the title WIP: Add support for Google Hangouts / Google Meet Add support for Google Hangouts / Google Meet Jan 5, 2019
@bbondy bbondy self-assigned this Jan 5, 2019
@bbondy bbondy requested a review from emerick January 5, 2019 23:01
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit ed326d6 into master Jan 8, 2019
bbondy added a commit that referenced this pull request Jan 8, 2019
Add support for Google Hangouts / Google Meet
bbondy added a commit that referenced this pull request Jan 8, 2019
Add support for Google Hangouts / Google Meet
@bbondy bbondy added this to the 0.61.x - Nightly milestone Jan 14, 2019
@bsclifton bsclifton deleted the hangouts branch January 24, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Hangouts / Google Meet: Screenshare feature is non-functional
2 participants