Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(uplift to 1.36.x) Add signing eip712 for hardware accounts (#12265) #12339

Merged
merged 1 commit into from
Feb 22, 2022
Merged

(uplift to 1.36.x) Add signing eip712 for hardware accounts (#12265) #12339

merged 1 commit into from
Feb 22, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 18, 2022 •
edited by kjozwiak
Loading

Uplift of #12265
Resolves brave/brave-browser#18833

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@spylogsster spylogsster requested a review from a team February 18, 2022 17:45
@spylogsster spylogsster requested a review from a team as a code owner February 18, 2022 17:45
@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build labels Feb 18, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak kjozwiak added this to the 1.36.x - Beta milestone Feb 22, 2022
kjozwiak
kjozwiak approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.36.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #12265 (comment).

@kjozwiak kjozwiak merged commit 8df945c into 1.36.x Feb 22, 2022
@kjozwiak kjozwiak deleted the pr12265_uplift_1.36.x branch February 22, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@spylogsster spylogsster

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.36.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@spylogsster @brave-builds @kjozwiak