-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a build bisect script #1833
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
changed the title
WIP: Implement a build bisect script
Implement a build bisect script
Mar 7, 2019
bsclifton
requested review from
GeetaSarvadnya,
kjozwiak,
LaurenWags,
bbondy,
rebron,
srirambv,
btlechowski and
jumde
March 7, 2019 19:34
bsclifton
changed the title
Implement a build bisect script
WIP: Implement a build bisect script
Mar 11, 2019
bsclifton
changed the title
WIP: Implement a build bisect script
Implement a build bisect script
Mar 11, 2019
bsclifton
changed the title
Implement a build bisect script
WIP: Implement a build bisect script
Mar 11, 2019
- fetches all versions - will attempt to find good/bad for start - search is not specific enough, but good enough for a rev1 - need to implement install / execute
…eded to return attempts)
…d/bad versions, fixed linting errors - `--fresh-profile` is intended to move your existing profile out of the way - `--use-profile` is intended to allow for downloading/unzipping a profile to use for all tests - if good version is not found, it'll use the first version match for "major.minor." pattern - if bad version is not found, it'll use the last version match for "major.minor." pattern
Feature requestsI'll make sure to create an issue for these 😄 These were items that came from folks during our company brown-bag presentation of the tool
Refactoring notesAreas where the code could be cleaner
|
bsclifton
changed the title
WIP: Implement a build bisect script
Implement a build bisect script
Mar 15, 2019
Ready for review - needs token for use, but otherwise is documented and ready to go 😄 |
mbacchi
approved these changes
Mar 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it!
This was referenced Mar 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Goal is to have a script that automates downloading/installing versions of browser for your platform
WIP checklist
TODOs before it's ready:
Reviewer notes
.npmrc
with an entry likeBRAVE_GITHUB_TOKEN=<TOKEN-GOES-HERE>
--real-profile
option!)python ./script/build-bisect.py
--good=
and--bad=
parameters--verbose
will show where in the binary search you arey
orn
to the prompt