-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Youtube and Twitch videos now provide more accurate times than before #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jasonrsadler please rebase |
Done. |
bbondy
changed the title
Youtube and Twitch videos now provide more accurate times than before
WIP: Youtube and Twitch videos now provide more accurate times than before
Oct 2, 2018
NejcZdovc
changed the title
WIP: Youtube and Twitch videos now provide more accurate times than before
Youtube and Twitch videos now provide more accurate times than before
Oct 2, 2018
…es time recording for media publishers
NejcZdovc
approved these changes
Oct 2, 2018
NejcZdovc
added a commit
that referenced
this pull request
Oct 2, 2018
Youtube and Twitch videos now provide more accurate times than before
NejcZdovc
added a commit
that referenced
this pull request
Oct 2, 2018
Youtube and Twitch videos now provide more accurate times than before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#971
Fixes brave/brave-browser#1277
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
publisher_info_db
with actual viewing time.Repeat Previous tests using Youtube live streams
publisher_info_db
with actual viewing time.publisher_info_db
with actual viewing time.Reviewer Checklist:
Additional Information
publisher_info.db
are updated at 10 seconds and then once every ~40 seconds after