-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable WebTorrent in Tor profile #554
Conversation
return false; | ||
} | ||
|
||
return ui_data->GetTorProfileService(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we do something like return ui_data->GetTorProfileService() ? true : false;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, addressed in df81708
a35d1f4
to
a3fb805
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Disable WebTorrent in Tor profile
Disable WebTorrent in Tor profile
Fix brave/brave-browser#1134
Don't redirect magnet and .torrent URLs to webtorrent component extension in Tor profile so they won't use WebTorrent.
Only added tests in brave_torrent_redirect_network_delegate_helper for .torrent case but didn't add tests for IsWebtorrentEnabled change because it's quite trivial.
Submitter Checklist:
git rebase -i
to squash commits (if needed).Test Plan:
manual test:
4. Right click a magnet link to open it in a new tab will shows the same prompt as 3 in the new tab.
unit test:
npm run test -- brave_unit_tests --filter=BraveTorrentRedirectNetworkDelegateHelperTest.*
Reviewer Checklist: