Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed rewards settings bundle creation on Android #710

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Oct 23, 2018

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Closes brave/brave-browser#1801

@SergeyZhukovsky SergeyZhukovsky changed the title Fixed rewards settings creation on Android Fixed rewards settings bundle creation on Android Oct 23, 2018
@NejcZdovc
Copy link
Contributor

@SergeyZhukovsky can you please create issue for it an add auto closing tag into the commit

@SergeyZhukovsky SergeyZhukovsky merged commit e5e45dc into master Oct 23, 2018
@NejcZdovc NejcZdovc deleted the html_android_fix branch October 23, 2018 14:14
NejcZdovc pushed a commit that referenced this pull request Oct 24, 2018
Fixed rewards settings bundle creation on Android
NejcZdovc pushed a commit that referenced this pull request Oct 24, 2018
Fixed rewards settings bundle creation on Android
NejcZdovc pushed a commit that referenced this pull request Oct 24, 2018
Fixed rewards settings bundle creation on Android
@NejcZdovc
Copy link
Contributor

master e5e45dc
0.57.x 13d24ae
0.56.x b646472
0.55.x a368445

@bbondy
Copy link
Member

bbondy commented Oct 30, 2018

Changing merged label to 0.56.x since this won't be included with 0.55.x hotfix2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android bundle build of rewards settings fails
3 participants