Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Implement 'Bookmark all tabs' #4132

Closed
soner-yuksel opened this issue Sep 3, 2021 · 1 comment · Fixed by #4133
Closed

Implement 'Bookmark all tabs' #4132

soner-yuksel opened this issue Sep 3, 2021 · 1 comment · Fixed by #4133

Comments

@soner-yuksel
Copy link
Contributor

Feature Overview

Add an option to long press action menu for bookmarking all existing tabs.

Design

1

Implementation Details

  • Do not show Bookmark All Tabs action If there is not active tabs that can open a website
  • Do not save tabs where url is not navigating to a website
  • Show a Add Folder Screen to let user figure out where to add the bookmarks and name folder

User Experience

  1. Long Press Tabs button in bottom action bar
  2. Press Bookmark All Tabs
  3. Choose folder to save
@srirambv
Copy link
Contributor

![image](https://user-images.githubusercontent.com/17010094/138276342-4236655e-ebc3-4164-8cf7-8bcc0e98e4e3.png)Verification passed on iPhone 7+ with iOS 14.8 running 1.32.1(21.10.20.18)
  • Verified long press on the tabs button shows Bookmark All Tabs option
  • Verified selecting bookmark all tabs brings up the save bookmark modal and adds folder name as Saved Tabs
  • Verified clicking on Done adds a new folder with open tabs bookmarked in it
  • Verified clicking on the bookmarks inside the Save Tabs folder load correctly
  • Verified able to edit the folder name without issue or losing bookmarks
image image image image

Verification passed on iPhone XR with iOS 15.0.1 running 1.32.1(21.10.20.18)
  • Verified long press on the tabs button shows Bookmark All Tabs option
  • Verified selecting bookmark all tabs brings up the save bookmark modal and adds folder name as Saved Tabs
  • Verified clicking on Done adds a new folder with open tabs bookmarked in it
  • Verified clicking on the bookmarks inside the Save Tabs folder load correctly
  • Verified able to edit the folder name without issue or losing bookmarks
image image image image

Verification passed on iPad Pro with iOS 15.1 Beta 3 running 1.32.1(21.10.20.18)
  • Verified long press on the tabs button shows Bookmark All Tabs option
  • Verified selecting bookmark all tabs brings up the save bookmark modal and adds folder name as Saved Tabs
  • Verified clicking on Done adds a new folder with open tabs bookmarked in it
  • Verified clicking on the bookmarks inside the Save Tabs folder load correctly
  • Verified able to edit the folder name without issue or losing bookmarks
image image image image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.