Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add option to disable 'Add to playlist' toolbar button #4234

Closed
Tracked by #389
iccub opened this issue Sep 27, 2021 · 8 comments · Fixed by #4235
Closed
Tracked by #389

Add option to disable 'Add to playlist' toolbar button #4234

iccub opened this issue Sep 27, 2021 · 8 comments · Fixed by #4235

Comments

@iccub
Copy link
Contributor

iccub commented Sep 27, 2021

Add new toggle under playlist settings
Title: Enable toolbar button, no footer text.
The setting should be enabled by default.

Put it at the top, above show notification badge setting.

This setting should disable url button only, the menu item stays.

@anthonypkeane
Copy link

@iccub can you please add a screenshot of the new menu here so @rmcfadden3 can take a look and give it the ok?

@iccub
Copy link
Contributor Author

iccub commented Sep 29, 2021

It's the first option

Zrzut ekranu 2021-09-29 o 11 52 18

@iccub
Copy link
Contributor Author

iccub commented Sep 29, 2021

at first glance looks like we should capitalize first letters for it

@anthonypkeane anthonypkeane added the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Sep 29, 2021
@anthonypkeane
Copy link

@iccub I want to block this one for a moment until @rmcfadden3 has reviewed the copy.

@rmcfadden3
Copy link

@anthonypkeane — how's this?

Header: Enable quick-access button
Body: Adds a playlist button (it looks like 4 lines with a + symbol) beside the address bar in the Brave browser. This button gives you quick access to open Playlist, or add or remove media.

@anthonypkeane anthonypkeane removed the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Sep 29, 2021
@iccub
Copy link
Contributor Author

iccub commented Sep 30, 2021

After update

Zrzut ekranu 2021-09-30 o 11 38 03

@rmcfadden3
Copy link

It's maybe a little long, now that I see it in context. But I don't see anything obvious that we can cut. So, I'm calling this one good.

iccub added a commit that referenced this issue Oct 4, 2021
Co-authored-by: Michał Buczek <michal.buczek@protonmail.com>
@srirambv
Copy link
Contributor

srirambv commented Oct 8, 2021

Verification passed on the following devices running 1.32(21.10.6.16)

  • Verified the availability of the new settings and the position of the settings
  • Verified the setting is enabled by default
iPhone 7+ (iOS 14.8) iPhone XR (iOS 15.0.1) iPad Pro (iOS 15.1 Beta 3)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.