Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

"Copy clean URL" feature #6179

Closed
anthonypkeane opened this issue Oct 13, 2022 · 2 comments · Fixed by #7696
Closed

"Copy clean URL" feature #6179

anthonypkeane opened this issue Oct 13, 2022 · 2 comments · Fixed by #7696

Comments

@anthonypkeane
Copy link

anthonypkeane commented Oct 13, 2022

Description:

Per: brave/brave-browser#23315

Testing strategy:

Found in the following document: https://docs.google.com/document/d/1ea7eF3s0WTsTlmMPr8LYp5KUyNg8eK4omjizo27qvJE

Implement the "Copy clean URL" feature on iOS

@anthonypkeane anthonypkeane added blocked: needs info Needs further information before work can commence feature-request labels Oct 13, 2022
@anthonypkeane
Copy link
Author

@cuba cuba self-assigned this Apr 19, 2023
cuba added a commit that referenced this issue Jul 7, 2023
cuba added a commit that referenced this issue Aug 1, 2023
cuba added a commit that referenced this issue Aug 10, 2023
@cuba cuba removed the blocked: needs info Needs further information before work can commence label Aug 16, 2023
cuba added a commit that referenced this issue Aug 17, 2023
cuba added a commit that referenced this issue Sep 5, 2023
cuba added a commit that referenced this issue Sep 7, 2023
cuba added a commit that referenced this issue Sep 7, 2023
cuba added a commit that referenced this issue Sep 7, 2023
cuba added a commit that referenced this issue Sep 7, 2023
cuba added a commit that referenced this issue Sep 7, 2023
cuba added a commit that referenced this issue Sep 13, 2023
@iccub iccub added this to the 1.58 milestone Sep 15, 2023
iccub pushed a commit that referenced this issue Sep 15, 2023
@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 3, 2023

Verified on iPhone X running iOS 16.7 using version 1.58 (23.9.26.21)

Spec: https://docs.google.com/document/d/1ea7eF3s0WTsTlmMPr8LYp5KUyNg8eK4omjizo27qvJE

  • Verified Copy Clean Link option appears in the context menu for links as well as when long pressing on address bar.
  • Verified Copy Clean Link option cleans URL when used on page context menu and address bar.
  • Verified test scenarios on test page - https://fmarier.github.io/brave-testing/query-filter.html
  • Verified using Copy Clean Link on amazon product page strips params known to be specific to id, email or individual click

Example Amazon Product URL containing multiple id in params

Copy link

https://www.amazon.com/Honest-Company-Conscious-Plant-Based-Sustainable/dp/B07GS3Q397/ref=mp_s_a_1_4?crid=1EAQPHVE4LCMY&keywords=honest+diapers&qid=1696358517&rdc=1&sprefix=honest+diapers%2Caps%2C116&sr=8-4

Copy Clean Link

https://www.amazon.com/Honest-Company-Conscious-Plant-Based-Sustainable/dp/B07GS3Q397/ref=mp_s_a_1_4?keywords=honest+diapers&rdc=1&sr=8-4

Example Example Example
IMG_3556 2 IMG_3554 2 IMG_3553 2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants