Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7539: Add network level standard mode #7540

Merged
merged 6 commits into from
Jul 24, 2023
Merged

Fix #7539: Add network level standard mode #7540

merged 6 commits into from
Jul 24, 2023

Conversation

cuba
Copy link
Contributor

@cuba cuba commented May 30, 2023

Summary of Changes

This pull request fixes #7539

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@cuba cuba requested a review from a team as a code owner May 30, 2023 10:34
@cuba cuba force-pushed the js/network-level-aggressive-mode branch from e17c150 to 35139b9 Compare May 30, 2023 13:36
@cuba cuba force-pushed the js/network-level-aggressive-mode branch from 65793e0 to ca607f5 Compare June 19, 2023 12:08
@cuba cuba mentioned this pull request Jul 6, 2023
Merged
25 tasks
@cuba cuba force-pushed the js/network-level-aggressive-mode branch from ca607f5 to c4d3267 Compare July 7, 2023 18:01
@cuba cuba force-pushed the js/network-level-aggressive-mode branch from 1b5b508 to 0d92791 Compare July 14, 2023 18:13
@cuba cuba force-pushed the js/network-level-aggressive-mode branch from 0d92791 to dce9d38 Compare July 23, 2023 13:58
@cuba cuba added this to the 1.57 milestone Jul 24, 2023
@cuba cuba merged commit 397c715 into development Jul 24, 2023
@cuba cuba deleted the js/network-level-aggressive-mode branch July 24, 2023 15:27
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@cuba
Fix brave/brave-ios#7539: Add network level standard mode (brave/brav…
f0a4d51 
…e-ios#7540)

* Add network level aggressive mode

* Optimize loading filter lists

* Ensure our stats handle aggressive mode properly

* Fix third party check for stats and request blocking

* Make youtube adblocking always aggressive

* Fix comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

@Brandon-T Brandon-T Brandon-T approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.57
Development

Successfully merging this pull request may close these issues.

Add network level standard mode
3 participants
@cuba @Brandon-T @iccub