Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

SETTINGS: Spell-check: Languages #2183

Closed
generic-user opened this issue Jun 14, 2016 · 42 comments · Fixed by #11710
Closed

SETTINGS: Spell-check: Languages #2183

generic-user opened this issue Jun 14, 2016 · 42 comments · Fixed by #11710

Comments

@generic-user
Copy link

generic-user commented Jun 14, 2016

Test Plan

Ensure there is option to select spell check for different languages under about:preferences#general

Did you search for similar issues before submitting this one?
Yes, terms: spell check spell-check language
Describe the issue you encountered:
Is it possible to change the spell-check language, similar to chrome?
Expected behavior:
Right click --> set language ...

@bbondy
Copy link
Member

bbondy commented Jun 14, 2016

Setting the language in the general pane also changes the spell check language. Is there a need to set it differently from your language?

@generic-user
Copy link
Author

generic-user commented Jun 16, 2016

Selected language

In my preferences, on the general pane, the selected language is Dutch. The language that is being used for spell-checking, is English.

Here is an image of the preferences pane:

Preferences pane

Here is on image of the spell-checking in action:

spellcheck

Multi language support

I definitely have a need to be able to switch between multiple languages. My main language is dutch, but I do type a lot of English as well. So switching between spell-checking languages is a must.

How it should work:

For an example of how to implement it, one can look at how it was done in Chrome. Spell-checking in chrome.

@cezaraugusto cezaraugusto added enhancement needs-info Another team member needs information from the PR/issue opener. labels Jun 20, 2016
@luixxiul luixxiul added the l10n label Sep 2, 2016
@alexwykoff
Copy link
Contributor

+1 from support : https://linkbubble.zendesk.com/agent/tickets/5845

@svenl77
Copy link

svenl77 commented Nov 2, 2016

+1 It's really hard to answer in different languages with brave. Multilingual support is super important. Many of us work in there default language but need english and other languages in a daily basis because the web is global!

@bbondy bbondy added this to the 1.0.0 milestone Nov 4, 2016
@bbondy
Copy link
Member

bbondy commented Nov 4, 2016

which operating system?

@srirambv
Copy link
Collaborator

srirambv commented Dec 6, 2016

+1 from support

@cndouglas cndouglas removed the needs-info Another team member needs information from the PR/issue opener. label Apr 11, 2017
@cndouglas
Copy link

+1 from #8226

@ForumLiker
Copy link

How can I change the spell-checking?

@ekalafatic
Copy link

@generic-user it doesn't work with Spanish language.
Definitely I can't use this browser professionally if I don't have minimally a spell-checker to write without some spelling error.

@srirambv
Copy link
Collaborator

@srirambv
Copy link
Collaborator

@benoitjpnet
Copy link

The priority of this issue should be bumped to maximal… This is a really important feature!

@argumento
Copy link

+1 I really need the ability to switch from english to spanish. I'm running Brave in Linux (ubuntu), I hope Brave will be compatible with some of the linux compatible dictionaries (hunspell, aspell).

Thanx for a great Browser!!

@eljuno
Copy link
Contributor

eljuno commented Jul 22, 2017

+1 from community

@Jacalz
Copy link
Contributor

Jacalz commented Jul 23, 2017

+1 from me

@eljuno
Copy link
Contributor

eljuno commented Jul 28, 2017

+1 from community

@hugobuddel
Copy link
Contributor

+1 this makes brave useless for me half the time. Having the red wiggles is very annoying

@eljuno
Copy link
Contributor

eljuno commented Aug 10, 2017

+1 from community

@CapitanPlanet
Copy link

+1 extra important

@L4rryk
Copy link

L4rryk commented Aug 22, 2017

+1 it is irritating me! Hope it will B fixed.

@Mibou
Copy link

Mibou commented Aug 23, 2017

+1

1 similar comment
@polygon5
Copy link

+1

@GGurtner
Copy link

Please, please, do not make spellcheck language follow the keyboard layout, this is going to be a nightmare for people like me constantly switching between languages and keyboards!

+1 to changing spellcheck language with a right click

@Acme908
Copy link

Acme908 commented Oct 19, 2017

Waiting for spell check to Portuguese Brazil.
Brave only have Portuguese BR in interface, but not in spell check

@marcospds
Copy link

This issue has been resolved? Temporary until I can solve it, I made a backup of the file en-US-7-1.bdic and I overwritten it inside ~\AppData\Local\brave\app-0.19.53\Dictionaries by the file pt-BR-3- 0.bdic from Chrome, while retaining the name en-US-7-1.bdic.

@darkdh
Copy link
Member

darkdh commented Oct 26, 2017

@marcospds nice hack. I'm working on it and almost finish. Please stay tune for a little while 😉

@Acme908
Copy link

Acme908 commented Oct 26, 2017

@marcospds WHOA!
I had uninstalled Brave, I'll try it now

EDIT:
For me, don't exist Dictionaries folder =\

@marcospds
Copy link

marcospds commented Oct 26, 2017

@Acme908 Do you use Windows?
With Brave open, open the task manager, find brave.exe under Process, click with right and go to "open file location".

@hugobuddel
Copy link
Contributor

hugobuddel commented Nov 3, 2017

I was really excited about this fix, but now I'm disappointed very happy. It seems that it is necessary to restart Brave when changing the spell check language?

I switch languages several times a day. My native tongue is Dutch, but about half of my communication is in English (mostly the professional part). So half of my emails are in Dutch, the other half in English. It should not be is not necessary to restart the browser ten times a day only to compose text in different languages.

Edit: Oops sorry seems I was mistaken! It does multiple languages at the same time! I got confused by the preferences window.

@bbondy
Copy link
Member

bbondy commented Nov 6, 2017

why not just add both language?

@hugobuddel
Copy link
Contributor

Yeah I figured that it's possible to use multiple languages, so did that now.

I got confused because the spacing between 'language' and 'enable spellcheck' is smaller than the subsequent spacing between 'enable spellcheck' and 'spellcheck languages'. So I thought that 'enable spellcheck' referred to the 'language' just above and didn't notice the more distant 'spellcheck languages' below it. Yeah seems stupid in retrospect, but don't make me think is a good approach to usability.

All the other switches correspond to the item above the switch (like the bookmark-bar switch); that is, the structure of the general settings page seems to be: dropdown/textfield/button optionally followed by switches. Only the spellcheck section has the order inverted. The other settings pages have section headers and those pages are much clearer; perhaps add headers to the general settings as well?

@Darkfae
Copy link

Darkfae commented Jan 14, 2018

+1 for the option to select multiple languages.

I'd also like to see more language options as well. The language settings are super limited right now, and it's driving me a bit nuts - being told my spelling is incorrect when I know it's right is a huge turn off.

@cndouglas
Copy link

@Darkfae You can use multiple languages. See Preferences > General > Spell Check Languages. Here's an example of English and Spanish:

RQF7 referenced this issue in RQF7/proyecto_lovelace Jan 26, 2018
Redacción impersonal. Fórmulas seguidas en un solo entorno: align.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.