Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Descenders affect spacing between top border and content #144

Closed
brechtm opened this issue Mar 3, 2020 · 0 comments
Closed

Descenders affect spacing between top border and content #144

brechtm opened this issue Mar 3, 2020 · 0 comments
Labels
bug easy A good candidate for a newcomer to debug

Comments

@brechtm
Copy link
Owner

brechtm commented Mar 3, 2020

The first flowable on a page receives descender=0 on rendering. This causes a difference in the rendering of the two admonitions below:

.. Hint:: It's bigger than a bread box.

.. Hint:: It's bigger than a bread box.

When rendering a top border, the cursor should probably be moved by - descender and the descender passed to the content should equal 0.

Something similar needs to be performed on rendering the bottom border.
@brechtm brechtm added easy A good candidate for a newcomer to debug bug labels Mar 3, 2020
brechtm added a commit that referenced this issue Jun 18, 2021
@brechtm
Update test reference PDFs
4054539 
The fix for #144 affects the rendering of many of the tests.

Note: the 'footnote_descender_overflow' test seems to duplicate part of
the 'footnote' test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug easy A good candidate for a newcomer to debug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brechtm