-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I269 citation definitions in body #271
I269 citation definitions in body #271
Conversation
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
==========================================
+ Coverage 73.76% 73.80% +0.04%
==========================================
Files 90 90
Lines 14288 14318 +30
Branches 1969 1972 +3
==========================================
+ Hits 10539 10567 +28
- Misses 3376 3377 +1
- Partials 373 374 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…rgus/rinohtype into i269-citation-definitions-in-body
Thanks for this @alexfargus. Sorry this took so long to review! I've generalized the code so that as_footnote will also work for plain footnotes. I'll commit those changes soon. I think I'll also replace as_footnote with target (accepts in-place or footnote) so that it's ready to accept additional options (endnote, bibliography?). Suggestions for better labels are welcome :-) |
This should address the first issue of #269 - displaying the definition in the body of the document. Creating References section is not covered here.
Changing the styling using
as_footnote
allows the user to specify whether the target of the citation reference is displayed as a footnote or in the section where it is declared.The existing behaviour has been kept with
as_footnote
set toTrue
by default.