Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SQS partial batch failure #1113

Merged
merged 7 commits into from
Jan 8, 2022

Conversation

t-richard
Copy link
Member

@t-richard t-richard commented Dec 6, 2021

Allows to support the recent addition for partial batch failures with SQS.

The syntax looks like this

image

Todo:

  • Feature
  • Deploy & test
  • Automated Tests
  • Documentation

@mnapoli
Copy link
Member

mnapoli commented Dec 13, 2021

That looks perfect, thank you for contributing that!

Regarding documentation, I guess it should go in this section: https://bref.sh/docs/function/handlers.html#sqs-events

I was thinking that eventually it could be interesting to have a dedicated Async workers page in the documentation about SQS, because right now it's a bit hidden in "Typed handlers" (and it's a very common use case for PHP apps). But I'm just sharing that to gauge the idea, this isn't something we need to do right now.

Added documentation for the `functionResponseType` key
Copy link
Member

@mnapoli mnapoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will probably merge and release tomorrow if nobody else has other comments.

Thanks!

@mnapoli
Copy link
Member

mnapoli commented Jan 8, 2022

Tomorrow = a week later in open-source world of course 😄

Thank you @t-richard!

@mnapoli mnapoli merged commit c4bbadb into brefphp:master Jan 8, 2022
@t-richard t-richard deleted the sqs-handler-partial-failure branch January 8, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants