Make sure /tmp/log dir exists
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-richard
requested changes
Jul 8, 2021
There was a problem hiding this comment.
Thanks for starting this!
Just a minor comment.
Could you also add tests that tries to write to the log dir directly ? I'd say one in an http context and one in a console context.
We had some differences in the past between the lifecycle of the Kernel in console and in http, so better be on the safe side of things 🙂
You can take a look at existing tests, they already do that (run the console and http request).
mnapoli
reviewed
Jul 8, 2021
There was a problem hiding this comment.
On top of @t-richard's comment about tests, I've added minor feedback.
Thanks a lot for taking the time to fix this!
| * Even though applications should never write into it on Lambda, there are parts of Symfony | ||
| * (like "about" CLI command) that expect the log dir exists, so we have to make sure of it. | ||
| * | ||
| * @see https://github.com/brefphp/symfony-bridge/issues/42 |
There was a problem hiding this comment.
Awesome thanks for the comment, that makes maintenance much easier!
|
Thank you @vhenzl and @t-richard! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #42.